Handle schema less url for proxy and concat

When proxying a url without a schema, we should add the gadget schema to the url.

[zhoresh, 2010-10-23 00:02:00]

Alternate solution, support schema-less when parsing a request instead of
creation

[zhoresh, 2010-10-25 16:10:04]

Fixing tests

[fargo, 2010-10-25 22:57:42]

LGTM

http://codereview.appspot.com/2622042/diff/4002/java/gadgets/src/main/java/or...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java
(right):

http://codereview.appspot.com/2622042/diff/4002/java/gadgets/src/main/java/or...
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java:204:
endToken = endToken + "/";
technically this is unnecessary, though the resulting syntax can be quite ugly
indeed:
/gadgets/container=foo&gadget=bar/proxyhttp://www.foo.com...

...will break in this case. If we add this in the process step we may want to
ensure it's there in the corresponding make(...)

http://codereview.appspot.com/2622042/diff/4002/java/gadgets/src/test/java/or...
File
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManagerTest.java
(right):

http://codereview.appspot.com/2622042/diff/4002/java/gadgets/src/test/java/or...
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManagerTest.java:48:
private static final Uri RESOURCE_3 = Uri.parse("//foobar.com/three.dat");
nit: might want to call this one RESOURCE_3_NOSCHEMA

[zhoresh, 2010-10-26 00:22:25]

Committed to r1027321

On Mon, Oct 25, 2010 at 3:57 PM, <fargo@google.com> wrote:

> LGTM
>
>
>
>
>
http://codereview.appspot.com/2622042/diff/4002/java/gadgets/src/main/java/or...
> File
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java
> (right):
>
>
>
http://codereview.appspot.com/2622042/diff/4002/java/gadgets/src/main/java/or...
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java:204:
> endToken = endToken + "/";
> technically this is unnecessary, though the resulting syntax can be
> quite ugly indeed:
> /gadgets/container=foo&gadget=bar/proxyhttp://www.foo.com...
>
> ...will break in this case. If we add this in the process step we may
> want to ensure it's there in the corresponding make(...)
>

The reason for this fix is because make already add this extra '/' in line
136
:-)


>
>
http://codereview.appspot.com/2622042/diff/4002/java/gadgets/src/test/java/or...
> File
>
>
>
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManagerTest.java
> (right):
>
>
>
http://codereview.appspot.com/2622042/diff/4002/java/gadgets/src/test/java/or...
>
>
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManagerTest.java:48:
> private static final Uri RESOURCE_3 =
> Uri.parse("//foobar.com/three.dat");
> nit: might want to call this one RESOURCE_3_NOSCHEMA

Done

>
>
> http://codereview.appspot.com/2622042/
>

[fargo, 2010-10-26 00:23:26]

On Mon, Oct 25, 2010 at 5:22 PM, Ziv Horesh <zhoresh@gmail.com> wrote:

> Committed to r1027321
>
> On Mon, Oct 25, 2010 at 3:57 PM, <fargo@google.com> wrote:
>
>> LGTM
>>
>>
>>
>>
>>
http://codereview.appspot.com/2622042/diff/4002/java/gadgets/src/main/java/or...
>> File
>>
>>
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java
>> (right):
>>
>>
>>
http://codereview.appspot.com/2622042/diff/4002/java/gadgets/src/main/java/or...
>>
>>
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java:204:
>> endToken = endToken + "/";
>> technically this is unnecessary, though the resulting syntax can be
>> quite ugly indeed:
>> /gadgets/container=foo&gadget=bar/proxyhttp://www.foo.com...
>>
>> ...will break in this case. If we add this in the process step we may
>> want to ensure it's there in the corresponding make(...)
>>
>
> The reason for this fix is because make already add this extra '/' in line
> 136
> :-)
>

Weak sauce, who wrote that? :)


>
>
>>
>>
http://codereview.appspot.com/2622042/diff/4002/java/gadgets/src/test/java/or...
>> File
>>
>>
>>
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManagerTest.java
>> (right):
>>
>>
>>
http://codereview.appspot.com/2622042/diff/4002/java/gadgets/src/test/java/or...
>>
>>
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManagerTest.java:48:
>> private static final Uri RESOURCE_3 =
>> Uri.parse("//foobar.com/three.dat");
>> nit: might want to call this one RESOURCE_3_NOSCHEMA
>
> Done
>
>>
>>
>> http://codereview.appspot.com/2622042/
>>
>
>