Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1279)

Issue 261040043: ibus-daemon update user cache when user observed path is updated (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 7 months ago by fujiwara
Modified:
8 years, 7 months ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

ibus-daemon update user cache when user observed path is updated After the system registry cache is generated by root, the cache remembers the observed path exists in /root == '~' but if a user updates the user observed path, the observed path exists in '~' and ibus-daemon cannot get the updated mtime because the cache refers the root directory but not the user directory. The patch tries to save '~' instead of the actual home dir in the cache. BUG=https://github.com/ibus/ibus/issues/1815 R=Shawn.P.Huang@gmail.com Committed: 1d678673e18e132ed53df32502b779b0a56314d5

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated with message #2. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -18 lines) Patch
M configure.ac View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ibusobservedpath.c View 1 5 chunks +21 lines, -15 lines 0 comments Download
M src/ibusregistry.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
fujiwara
8 years, 7 months ago (2015-09-02 09:13:35 UTC) #1
Peng
https://codereview.appspot.com/261040043/diff/1/src/ibusobservedpath.c File src/ibusobservedpath.c (right): https://codereview.appspot.com/261040043/diff/1/src/ibusobservedpath.c#newcode300 src/ibusobservedpath.c:300: path->path = g_build_filename (homedir, node->text + 2, NULL); How ...
8 years, 7 months ago (2015-09-05 13:02:08 UTC) #2
fujiwara
https://codereview.appspot.com/261040043/diff/1/src/ibusobservedpath.c File src/ibusobservedpath.c (right): https://codereview.appspot.com/261040043/diff/1/src/ibusobservedpath.c#newcode300 src/ibusobservedpath.c:300: path->path = g_build_filename (homedir, node->text + 2, NULL); On ...
8 years, 7 months ago (2015-09-07 07:07:30 UTC) #3
Peng
On 2015/09/07 07:07:30, fujiwara wrote: > https://codereview.appspot.com/261040043/diff/1/src/ibusobservedpath.c > File src/ibusobservedpath.c (right): > > https://codereview.appspot.com/261040043/diff/1/src/ibusobservedpath.c#newcode300 > ...
8 years, 7 months ago (2015-09-07 17:53:16 UTC) #4
fujiwara
8 years, 7 months ago (2015-09-08 04:01:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1d678673e18e132ed53df32502b779b0a56314d5 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b