Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1159)

Issue 260400043: Don't print redundant flags in chords

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 8 months ago by david.nalesnik
Modified:
8 years, 8 months ago
Reviewers:
pkx166h
CC:
lilypond-devel_gnu.com
Visibility:
Public.

Description

Don't print redundant flags in chords This patch adds a check to lily/stem-engraver.cc which ensures that only one Flag grob appears for a given Stem grob. Previously, a flag was created and printed for each note of a chord.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M lily/stem-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6
david.nalesnik
Please review. Thanks!
8 years, 8 months ago (2015-08-24 23:53:47 UTC) #1
david.nalesnik
This is a fix for a bug reported here: http://lists.gnu.org/archive/html/bug-lilypond/2015-08/msg00080.html The patch can be tested ...
8 years, 8 months ago (2015-08-25 00:01:11 UTC) #2
pkx166h
Passes make, make check and a full make doc PATCH-REVIEW
8 years, 8 months ago (2015-08-25 07:22:39 UTC) #3
pkx166h
Patch on countdown for August 29th PATCH_COUNTDOWN
8 years, 8 months ago (2015-08-26 07:09:11 UTC) #4
pkx166h
Patch counted down - please push. PATCH_PUSH
8 years, 8 months ago (2015-08-29 07:46:31 UTC) #5
david.nalesnik
8 years, 8 months ago (2015-08-29 13:30:33 UTC) #6
On 2015/08/29 07:46:31, J_lowe wrote:
> Patch counted down - please push.
> 
> PATCH_PUSH

Pushed.

author	David Nalesnik <david.nalesnik@gmail.com>	
Mon, 24 Aug 2015 14:13:31 +0000 (09:13 -0500)
committer	David Nalesnik <david.nalesnik@gmail.com>	
Sat, 29 Aug 2015 12:57:18 +0000 (07:57 -0500)
commit	555eba6c5d21610b1ad87a68a4304946212fb69d
tree	f7a8c26ef9f3ad0a341bb01ad4239e97687864d3	
parent	a832764e7300d48468a6812077b899a4beed271b
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b