PATCH: Change PDF 'author' field to use /Author

PATCH: Change PDF 'author' field to use /Author

Currently, the PDF author field is
filled with the composer. This is
nice fall back but in most cases
the author of the document and the
composer will be different. While
I can write pdfcomposer = "Author Name"
it appears as intended as /Author(Author Name)
but it also appears as /Composer(Author Name)
which is wrong.

Wouldn't it make sense to offer
both fields: Author and Composer
separately? A fallback if no
author is given makes sense but
it would be good to be able to
specify an author differing
from the composer.

[pkx166h, 2015-08-15 22:22:42]

This passes make, make check and a full make doc. However reg tests show
programming errors

for example

--snip--

 Writing ./voice-4-midi-systems.tex...
 Writing ./voice-4-midi-systems.count...
 Writing timing to voice-4-midi.profile...
+programming error: Parsed object should be dead: #<Context_def CueVoice
/home/james/lilypond-git/build/out/share/lilypond/current/ly/performer-init.ly:110:1>
+continuing, cross fingers
+programming error: Parsed object should be dead: #<Prob: Music C++:
Music((origin . #<location out-test/voice-4-midi.ly:72:3>))((display-methods
#<procedure #f (check)>) (name . BarCheck) (types bar-check) (iterator-ctor .
#<primitive-procedure ly:bar-check-iterator::constructor>)) >
+
+continuing, cross fingers


input/regression/midi/voice-4-midi.log

--snip--

MOst (if not all of the Midi reg tests show this same error)

[Dan Eble, 2015-08-15 23:41:37]

https://codereview.appspot.com/260200043/diff/1/scm/framework-ps.scm
File scm/framework-ps.scm (right):

https://codereview.appspot.com/260200043/diff/1/scm/framework-ps.scm#newcode462
scm/framework-ps.scm:462: (metadata-lookup-output 'pdfauthor 'composer "Author")
If I understand the reason for this, it is only half done.  If it does not make
sense to assume that 'pdfcomposer is the author of the document, then it does
not make sense to assume that 'composer is either.  The question is, why assume
that the composer is the author?  Why not the arranger?  Why not the poet?

Maybe there should be no fallback for pdfauthor, or maybe Lilypond should be
given a new header field that means what the PDF Author field means.

(Also -- not a problem with this patch -- where's the credit for translators?)

[mail_philholmes.net, 2015-08-18 14:07:50]

----- Original Message ----- 
From: <nine.fierce.ballads@gmail.com>
To: <pkx166h@gmail.com>
Cc: <reply@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org>
Sent: Sunday, August 16, 2015 12:41 AM
Subject: Re: PATCH: Change PDF 'author' field to use /Author (issue 
260200043by pkx166h@gmail.com)


>
> https://codereview.appspot.com/260200043/diff/1/scm/framework-ps.scm
> File scm/framework-ps.scm (right):
>
>
https://codereview.appspot.com/260200043/diff/1/scm/framework-ps.scm#newcode462
> scm/framework-ps.scm:462: (metadata-lookup-output 'pdfauthor 'composer
> "Author")
> If I understand the reason for this, it is only half done.  If it does
> not make sense to assume that 'pdfcomposer is the author of the
> document, then it does not make sense to assume that 'composer is
> either.  The question is, why assume that the composer is the author?
> Why not the arranger?  Why not the poet?
>
> Maybe there should be no fallback for pdfauthor, or maybe Lilypond
> should be given a new header field that means what the PDF Author field
> means.


I think the best bet would be to treat author in the same way as keywords 
and subject.  Neither of these is a true header field in Lilypond, in that 
they do not appear on the printed page.  However, both do appear in the PDF 
properties and both can be prefixed with 'pdf', like the 'true' header 
properties.  We would then simply have

(metadata-lookup-output 'pdfauthor 'author "Author")

as the relevant line.

--
Phil Holmes 

[pkx166h, 2017-03-19 14:03:53]

author	Phil Holmes <mail@philholmes.net>	
	Sun, 30 Aug 2015 15:04:59 +0000 (16:04 +0100)
committer	Phil Holmes <mail@philholmes.net>	
	Sun, 6 Sep 2015 09:59:52 +0000 (10:59 +0100)
commit	9cd96a9f2f66f8182099079685456a6e23c26862