Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3371)

Issue 260120043: Add terminator in NO_SNOOPER_APPS (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 7 months ago by fujiwara
Modified:
8 years, 7 months ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Add terminator in NO_SNOOPER_APPS terminator connects "key-press-event" signal in VTE and receives the KeyPress events and copies the events to the multiple terminals. If IBus uses snooper and IBusIMContext returns true, terminator cannot receive the IME events because VTE does not export IME "commit" signal. After move terminator in NO_SNOOPER_APPS, terminator can receive the KeyPress events from "key-press-event" signal before IBusIMContext key_press_event() class method receives the events. BUG=https://github.com/ibus/ibus/issues/1802 R=Shawn.P.Huang@gmail.com Committed: 173af53099633fa18713ac45f9f64b50607f83ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M configure.ac View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
fujiwara
8 years, 7 months ago (2015-08-13 09:56:40 UTC) #1
Peng
On 2015/08/13 09:56:40, fujiwara wrote: lgtm
8 years, 7 months ago (2015-08-13 14:01:58 UTC) #2
fujiwara
8 years, 7 months ago (2015-08-14 02:24:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
173af53099633fa18713ac45f9f64b50607f83ff (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b