Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(449)

Issue 25940043: code review 25940043: gosshnew/ssh: reduce dependency on throughput in contro... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by hanwen-google
Modified:
10 years, 4 months ago
Reviewers:
agl1
CC:
agl1, dfc, jpsugar, golang-dev, hanwen-google
Visibility:
Public.

Description

gosshnew/ssh: make flow control tests time independent. Introduces test-only method remoteWindow.waitWriterBlocked.

Patch Set 1 #

Patch Set 2 : diff -r e9c12380607d https://hanwen%40google.com@code.google.com/p/gosshnew/ #

Total comments: 2

Patch Set 3 : diff -r bb3fb12a7883 https://hanwen%40google.com@code.google.com/p/gosshnew/ #

Patch Set 4 : diff -r bb3fb12a7883 https://hanwen%40google.com@code.google.com/p/gosshnew/ #

Patch Set 5 : diff -r cf4ae2982ebb https://hanwen%40google.com@code.google.com/p/gosshnew/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -111 lines) Patch
M ssh/common.go View 1 2 3 4 3 chunks +15 lines, -1 line 0 comments Download
M ssh/mux_test.go View 1 2 3 4 2 chunks +61 lines, -110 lines 0 comments Download

Messages

Total messages: 7
hanwen-google
Hello agl1, dave@cheney.net, jpsugar@google.com (cc: agl@golang.org, dave@cheney.net, golang-dev@googlegroups.com, hanwen@google.com, jpsugar@google.com), I'd like you to review ...
10 years, 4 months ago (2013-11-13 10:02:42 UTC) #1
jpsugar
https://codereview.appspot.com/25940043/diff/20001/ssh/mux_test.go File ssh/mux_test.go (right): https://codereview.appspot.com/25940043/diff/20001/ssh/mux_test.go#newcode138 ssh/mux_test.go:138: // although the big write has completed, we can't ...
10 years, 4 months ago (2013-11-13 22:26:40 UTC) #2
hanwen-google
On 2013/11/13 22:26:40, jpsugar wrote: > https://codereview.appspot.com/25940043/diff/20001/ssh/mux_test.go > File ssh/mux_test.go (right): > > https://codereview.appspot.com/25940043/diff/20001/ssh/mux_test.go#newcode138 > ...
10 years, 4 months ago (2013-11-14 09:10:20 UTC) #3
agl1
https://codereview.appspot.com/25940043/diff/20001/ssh/mux_test.go File ssh/mux_test.go (right): https://codereview.appspot.com/25940043/diff/20001/ssh/mux_test.go#newcode138 ssh/mux_test.go:138: // although the big write has completed, we can't ...
10 years, 4 months ago (2013-11-14 18:27:23 UTC) #4
hanwen-google
On 2013/11/14 18:27:23, agl1 wrote: > https://codereview.appspot.com/25940043/diff/20001/ssh/mux_test.go > File ssh/mux_test.go (right): > > https://codereview.appspot.com/25940043/diff/20001/ssh/mux_test.go#newcode138 > ...
10 years, 4 months ago (2013-11-15 11:34:24 UTC) #5
agl1
Note: you don't appear to have included the other files in this CL. But LGTM ...
10 years, 4 months ago (2013-11-15 16:19:23 UTC) #6
hanwen-google
10 years, 4 months ago (2013-11-16 10:16:38 UTC) #7
*** Submitted as https://code.google.com/p/gosshnew/source/detail?r=c697b9e62f7a
***

gosshnew/ssh: make flow control tests time independent.

Introduces test-only method remoteWindow.waitWriterBlocked.

R=agl, dave, jpsugar
CC=agl, dave, golang-dev, hanwen, jpsugar
https://codereview.appspot.com/25940043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b