Issue 25920043: cherrypick r2042 from trunk

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 25920043: cherrypick r2042 from trunk

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by fwereade

Modified:
10 years, 5 months ago

Reviewers:
jameinel, mp+195003

Visibility:
Public.

Description

cherrypick r2042 from trunk fixes lp:1233457 https://code.launchpad.net/~fwereade/juju-core/fix-1233457-for-1.16/+merge/195003 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+82 lines, -3 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/service.go	View	1 chunk	+7 lines, -3 lines	0 comments	Download
M	state/unit.go	View	1 chunk	+22 lines, -0 lines	0 comments	Download
M	state/unit_test.go	View	1 chunk	+51 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM on principle.

Expand All Messages | Collapse All Messages