Let \autochange accept optional arguments for the turning-point and clefs

Let \autochange accept optional arguments for the turning-point and clefs

Issue whatever

With the fix for issue 4465 bassStaffProperties and trebleStaffProperties are gone.
This patch reimplements the functionality to set clefs for the staves and offers the
possibility to set another turning-point apart from middle-C.
This is done with optional arguments for \autochange.

The regtest auto-change.ly is extended to reflect these possibilities as well as
Documentation/notation/keyboards.itely

Also inserting the usual remarks about license, etc

[thomasmorley651, 2015-07-30 20:10:17]

insert correct issue number into commit-message

[thomasmorley651, 2015-07-30 20:21:40]

Please review.

It's a pity that obviously putting something like #{ c' #} or #{ \clef bass #}
in music-functions-init.ly is currently not possible.
Trying so returns:
"
error: unrecognized string, not in text script or \lyricmode
  c'
"
or
"
error: unknown escaped string: `\clef'
 \clef treble 
"

It works in any user.ly-file, though.

[Dan Eble, 2015-07-31 00:01:20]

https://codereview.appspot.com/259080043/diff/20001/Documentation/notation/ke...
File Documentation/notation/keyboards.itely (right):

https://codereview.appspot.com/259080043/diff/20001/Documentation/notation/ke...
Documentation/notation/keyboards.itely:294: If the staves are not instantiated
explicitely other clefs may be used.
explicitly,
          ^
(correct spelling and insert comma)

https://codereview.appspot.com/259080043/diff/20001/input/regression/auto-cha...
File input/regression/auto-change.ly (right):

https://codereview.appspot.com/259080043/diff/20001/input/regression/auto-cha...
input/regression/auto-change.ly:10: If the staves are not instantiated
explicitely, other clefs may be specified.
IMO the new cases covering \with {} deserve to be in a separate file.  I
probably would have made a separate file for the case covering the specified
switch point too.

https://codereview.appspot.com/259080043/diff/20001/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):

https://codereview.appspot.com/259080043/diff/20001/ly/music-functions-init.l...
ly/music-functions-init.ly:204: Setting clefs works only for not explicitely
instantiated staves.")
not explicitly -> implicitly

https://codereview.appspot.com/259080043/diff/20001/ly/music-functions-init.l...
ly/music-functions-init.ly:210: \context Staff = "up" $clef-1
I don't understand why $ rather than #.  Is it my problem, or does it deserve a
comment?

https://codereview.appspot.com/259080043/diff/20001/scm/autochange.scm
File scm/autochange.scm (right):

https://codereview.appspot.com/259080043/diff/20001/scm/autochange.scm#newcode36
scm/autochange.scm:36: (cond ((ly:pitch<? ref-pitch pitch)
would ly:pitch-diff simplify this?

[dak, 2015-07-31 05:12:05]

https://codereview.appspot.com/259080043/diff/20001/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):

https://codereview.appspot.com/259080043/diff/20001/ly/music-functions-init.l...
ly/music-functions-init.ly:189: (ly:context-mod? #{ \with {
Write (ly:context-mod?) here and (or clef-1 #{ \with { \clef "treble" } #}) in
the code.  I'd not recommend doing the same for #{ c' #} since you cannot
predict the active notename language at the time of execution.

[thomasmorley651, 2015-07-31 10:38:38]

Adressing Dans and Davids comments

[thomasmorley651, 2015-07-31 10:42:38]

Thanks Dan and David for review

https://codereview.appspot.com/259080043/diff/20001/Documentation/notation/ke...
File Documentation/notation/keyboards.itely (right):

https://codereview.appspot.com/259080043/diff/20001/Documentation/notation/ke...
Documentation/notation/keyboards.itely:294: If the staves are not instantiated
explicitely other clefs may be used.
On 2015/07/31 00:01:19, Dan Eble wrote:
> explicitly,
>           ^
> (correct spelling and insert comma)

Done.

https://codereview.appspot.com/259080043/diff/20001/input/regression/auto-cha...
File input/regression/auto-change.ly (right):

https://codereview.appspot.com/259080043/diff/20001/input/regression/auto-cha...
input/regression/auto-change.ly:10: If the staves are not instantiated
explicitely, other clefs may be specified.
On 2015/07/31 00:01:19, Dan Eble wrote:
> IMO the new cases covering \with {} deserve to be in a separate file.  I
> probably would have made a separate file for the case covering the specified
> switch point too.

Done.

https://codereview.appspot.com/259080043/diff/20001/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):

https://codereview.appspot.com/259080043/diff/20001/ly/music-functions-init.l...
ly/music-functions-init.ly:189: (ly:context-mod? #{ \with {
On 2015/07/31 05:12:05, dak wrote:
> Write (ly:context-mod?) here and (or clef-1 #{ \with { \clef "treble" } #}) in
> the code.  I'd not recommend doing the same for #{ c' #} since you cannot
> predict the active notename language at the time of execution.

Done.

https://codereview.appspot.com/259080043/diff/20001/ly/music-functions-init.l...
ly/music-functions-init.ly:204: Setting clefs works only for not explicitely
instantiated staves.")
On 2015/07/31 00:01:19, Dan Eble wrote:
> not explicitly -> implicitly

Done.

https://codereview.appspot.com/259080043/diff/20001/ly/music-functions-init.l...
ly/music-functions-init.ly:210: \context Staff = "up" $clef-1
On 2015/07/31 00:01:19, Dan Eble wrote:
> I don't understand why $ rather than #.  Is it my problem, or does it deserve
a
> comment?

Well, it does not work with #. I'm not sure enough about the reasons to even try
an explanation.

https://codereview.appspot.com/259080043/diff/20001/scm/autochange.scm
File scm/autochange.scm (right):

https://codereview.appspot.com/259080043/diff/20001/scm/autochange.scm#newcode36
scm/autochange.scm:36: (cond ((ly:pitch<? ref-pitch pitch)
On 2015/07/31 00:01:20, Dan Eble wrote:
> would ly:pitch-diff simplify this?

I was not happy with this nested if/cond either, but I don't see how
ly:pitch-diff would help.

At least I managed to shorten it a bit in the newest patch-set

[dak, 2015-07-31 10:57:07]

https://codereview.appspot.com/259080043/diff/20001/scm/autochange.scm
File scm/autochange.scm (right):

https://codereview.appspot.com/259080043/diff/20001/scm/autochange.scm#newcode36
scm/autochange.scm:36: (cond ((ly:pitch<? ref-pitch pitch)
On 2015/07/31 10:42:38, thomasmorley651 wrote:
> On 2015/07/31 00:01:20, Dan Eble wrote:
> > would ly:pitch-diff simplify this?
> 
> I was not happy with this nested if/cond either, but I don't see how
> ly:pitch-diff would help.
> 
> At least I managed to shorten it a bit in the newest patch-set

Well, it does not appear to make sense to even look at the alteration here.  And
the original code doesn't do it either.  You could just use
(dir (if pitch (sign (- (ly:pitch-steps pitch) (ly:pitch-steps ref-pitch))) 0))
which is actually pretty close to the original.

[thomasmorley651, 2015-07-31 11:06:32]

Davids suggestion, thanks a lot

[thomasmorley651, 2015-07-31 11:16:28]

On 2015/07/31 10:57:07, dak wrote:
> https://codereview.appspot.com/259080043/diff/20001/scm/autochange.scm
> File scm/autochange.scm (right):
> 
>
https://codereview.appspot.com/259080043/diff/20001/scm/autochange.scm#newcode36
> scm/autochange.scm:36: (cond ((ly:pitch<? ref-pitch pitch)
> On 2015/07/31 10:42:38, thomasmorley651 wrote:
> > On 2015/07/31 00:01:20, Dan Eble wrote:
> > > would ly:pitch-diff simplify this?
> > 
> > I was not happy with this nested if/cond either, but I don't see how
> > ly:pitch-diff would help.
> > 
> > At least I managed to shorten it a bit in the newest patch-set
> 
> Well, it does not appear to make sense to even look at the alteration here. 
And
> the original code doesn't do it either.  You could just use
> (dir (if pitch (sign (- (ly:pitch-steps pitch) (ly:pitch-steps ref-pitch)))
0))
> which is actually pretty close to the original.

Much better, thanks.
Done.