Issue 258060043: Additional changes to review script #270.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 258060043: Additional changes to review script #270. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 8 months ago by Joachim Metz

Modified:
8 years, 8 months ago

Reviewers:
kiddi, log2timeline-maintainers, onager

CC:
log2timeline-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

Additional changes to review script #270.

Patch Set 2 : Added diffbase support. #

Patch Set 3 : Worked on diffbase support to review scripts. #

Total comments: 2

Patch Set 4 : Small changes. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -10 lines)			Patch
M	utils/merge_submit.sh	View	1 2 3	7 chunks	+16 lines, -0 lines	0 comments	Download
M	utils/review.sh	View	1 2 3	8 chunks	+32 lines, -9 lines	0 comments	Download
M	utils/update.sh	View	1 2	4 chunks	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 9

Expand All Messages | Collapse All Messages

kiddi

just one comment/question https://codereview.appspot.com/258060043/diff/40001/utils/merge_submit.sh File utils/merge_submit.sh (right): https://codereview.appspot.com/258060043/diff/40001/utils/merge_submit.sh#newcode92 utils/merge_submit.sh:92: git stash && git stash drop; ...

8 years, 8 months ago (2015-08-11 22:53:51 UTC) #4

Joachim Metz

https://codereview.appspot.com/258060043/diff/40001/utils/merge_submit.sh File utils/merge_submit.sh (right): https://codereview.appspot.com/258060043/diff/40001/utils/merge_submit.sh#newcode92 utils/merge_submit.sh:92: git stash && git stash drop; On 2015/08/11 22:53:51, ...

8 years, 8 months ago (2015-08-12 05:15:23 UTC) #5

onager

On 2015/08/17 06:12:04, Joachim Metz wrote: > Code updated. LGTM, this approach seems good to ...

8 years, 8 months ago (2015-08-17 18:03:15 UTC) #8

Message was sent while issue was closed.

Submitted

Expand All Messages | Collapse All Messages