Issue 257140043: Makes the power sample table use a timestamp span for its time data.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 257140043: Makes the power sample table use a timestamp span for its time data. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 8 months ago by charliea

Modified:
8 years, 8 months ago

Reviewers:
petrcermak

CC:
tracing-review_chromium.org

Base URL:
https://github.com/google/trace-viewer.git@master

Visibility:
Public.

More Reviews

Description

Makes the power sample table use a timestamp span for its time data. This is after nduca@ pointed out that I should be doing this after submitting a prior code review (http://bit.ly/1JHsyXb). BUG=#1108 R=petrcermak@chromium.org Committed: https://chromium.googlesource.com/external/trace-viewer/+/cac951b44f098a001066dfeb963cb43a34b30665

Patch Set 1 : #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	tracing/tracing/ui/analysis/power_sample_table.html	View		2 chunks	+4 lines, -1 line	0 comments	Download
	M	tracing/tracing/ui/analysis/power_sample_table_test.html	View		2 chunks	+4 lines, -1 line	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

petrcermak

LGTM with one comment. Thanks, Petr https://codereview.appspot.com/257140043/diff/20001/tracing/tracing/ui/analysis/power_sample_table_test.html File tracing/tracing/ui/analysis/power_sample_table_test.html (right): https://codereview.appspot.com/257140043/diff/20001/tracing/tracing/ui/analysis/power_sample_table_test.html#newcode12 tracing/tracing/ui/analysis/power_sample_table_test.html:12: <link rel="import" href="/ui/units/time_stamp_span.html"> ...

8 years, 8 months ago (2015-08-03 13:16:29 UTC) #2

charliea

Committed patchset #1 (id:20001) manually as cac951b44f098a001066dfeb963cb43a34b30665 (presubmit successful).

8 years, 8 months ago (2015-08-03 13:17:53 UTC) #3

charliea

8 years, 8 months ago (2015-08-03 13:18:25 UTC) #4

Message was sent while issue was closed.

https://codereview.appspot.com/257140043/diff/20001/tracing/tracing/ui/analys...
File tracing/tracing/ui/analysis/power_sample_table_test.html (right):

https://codereview.appspot.com/257140043/diff/20001/tracing/tracing/ui/analys...
tracing/tracing/ui/analysis/power_sample_table_test.html:12: <link rel="import"
href="/ui/units/time_stamp_span.html">
On 2015/08/03 13:16:29, petrcermak wrote:
> You don't need this import.

Done.

Expand All Messages | Collapse All Messages