Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(672)

Issue 25710043: page-breaking: allow ragged pages to be compressed; issue 3281

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by Keith
Modified:
10 years, 4 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Old error messages: 1) warning: cannot fit music on page: ragged-spacing was requested, but page was compressed 2) warning: cannot fit music on page: overflow is 13.096881 warning: compressing music to fit New error messages: 1) warning: ragged-bottom was specified, but page must be compressed warning: page 34 has been compressed 2) warning: compressing a over-full page by 13.1 staff-spaces warning: page 34 was compressed

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : backward compatibility for Werner #

Total comments: 3

Patch Set 4 : straightened logic #

Patch Set 5 : change only 'ragged-last-bottom' and print page numbers with any warning #

Total comments: 1

Patch Set 6 : adjust error-reporting #

Patch Set 7 : error messages #

Patch Set 8 : telegraphic style #

Patch Set 9 : a #

Patch Set 10 : b #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -20 lines) Patch
M Documentation/notation/spacing.itely View 1 2 3 4 5 6 7 2 chunks +12 lines, -12 lines 0 comments Download
M lily/page-breaking.cc View 1 2 3 4 5 6 7 8 9 3 chunks +9 lines, -4 lines 0 comments Download
M lily/page-layout-problem.cc View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -3 lines 0 comments Download
M lily/page-spacing.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8
lemzwerg
LGTM, thanks, with one comment. https://codereview.appspot.com/25710043/diff/40001/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): https://codereview.appspot.com/25710043/diff/40001/Documentation/notation/spacing.itely#newcode411 Documentation/notation/spacing.itely:411: Reading this it's not ...
10 years, 4 months ago (2013-11-14 05:49:27 UTC) #1
Keith
https://codereview.appspot.com/25710043/diff/40001/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): https://codereview.appspot.com/25710043/diff/40001/Documentation/notation/spacing.itely#newcode411 Documentation/notation/spacing.itely:411: On 2013/11/14 05:49:28, lemzwerg wrote: > Reading this it's ...
10 years, 4 months ago (2013-11-14 21:48:26 UTC) #2
lemzwerg
LGTM. Just to be sure: Does the warning message regarding forced compressed pages (if ragged-bottom ...
10 years, 4 months ago (2013-11-19 07:57:36 UTC) #3
Trevor Daniels
LGTM apart from a suggested doc change. https://codereview.appspot.com/25710043/diff/180001/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): https://codereview.appspot.com/25710043/diff/180001/Documentation/notation/spacing.itely#newcode401 Documentation/notation/spacing.itely:401: the last ...
10 years, 4 months ago (2013-11-19 08:59:17 UTC) #4
Keith
On 2013/11/19 07:57:36, lemzwerg wrote: > LGTM. Just to be sure: Does the warning message ...
10 years, 4 months ago (2013-11-19 09:16:34 UTC) #5
dak
On 2013/11/19 09:16:34, Keith wrote: > On 2013/11/19 07:57:36, lemzwerg wrote: > > LGTM. Just ...
10 years, 4 months ago (2013-11-19 09:31:24 UTC) #6
Keith
On 2013/11/19 08:59:17, Trevor Daniels wrote: > LGTM apart from a suggested doc change. Got ...
10 years, 4 months ago (2013-11-19 09:44:25 UTC) #7
Keith
10 years, 4 months ago (2013-11-19 09:48:47 UTC) #8
On 2013/11/19 09:31:24, dak wrote:
> 
> Can you see any effect from ragged-bottom in those runs of lilypond-book where
> the warning disappears?

No.
Changing the warning behavior was a side-topic, so I'm putting it back and
finishing the main issue alone.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b