Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(878)

Issue 255830043: Step 1 for unifying WinRegistry #145, #155. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 8 months ago by Joachim Metz
Modified:
8 years, 8 months ago
Reviewers:
kiddi, onager
CC:
log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

Step 1 for unifying WinRegistry #145, #155.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Uploading changes made to code. #

Total comments: 45

Patch Set 3 : Uploading changes made to code. #

Total comments: 4

Patch Set 4 : Changes after review. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1750 lines, -2037 lines) Patch
M plaso/engine/utils.py View 1 1 chunk +1 line, -1 line 0 comments Download
M plaso/frontend/preg.py View 1 2 3 9 chunks +76 lines, -91 lines 0 comments Download
M plaso/parsers/winreg.py View 1 2 chunks +3 lines, -3 lines 0 comments Download
M plaso/parsers/winreg_plugins/interface.py View 1 1 chunk +1 line, -1 line 0 comments Download
M plaso/preprocessors/interface.py View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M plaso/preprocessors/manager.py View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M plaso/preprocessors/windows.py View 1 2 3 chunks +229 lines, -343 lines 0 comments Download
A plaso/winnt/time_zones.py View 1 1 chunk +630 lines, -0 lines 0 comments Download
D plaso/winreg/__init__.py View 1 1 chunk +0 lines, -1 line 0 comments Download
D plaso/winreg/cache.py View 1 1 chunk +0 lines, -170 lines 0 comments Download
D plaso/winreg/interface.py View 1 1 chunk +0 lines, -211 lines 0 comments Download
M plaso/winreg/path_expander.py View 1 1 chunk +0 lines, -71 lines 0 comments Download
D plaso/winreg/utils.py View 1 1 chunk +0 lines, -28 lines 0 comments Download
D plaso/winreg/winpyregf.py View 1 2 1 chunk +0 lines, -400 lines 0 comments Download
M plaso/winreg/winregistry.py View 1 1 chunk +0 lines, -199 lines 0 comments Download
A + plaso/winregistry/__init__.py View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + plaso/winregistry/cache.py View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A plaso/winregistry/definitions.py View 1 1 chunk +35 lines, -0 lines 0 comments Download
A + plaso/winregistry/interface.py View 1 2 3 5 chunks +48 lines, -27 lines 0 comments Download
A + plaso/winregistry/path_expander.py View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
A + plaso/winregistry/regf.py View 1 2 3 9 chunks +160 lines, -149 lines 0 comments Download
A plaso/winregistry/registry.py View 1 2 1 chunk +521 lines, -0 lines 2 comments Download
M tests/parsers/winreg.py View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/parsers/winreg_plugins/appcompatcache.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winreg_plugins/default.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winreg_plugins/lfu.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/parsers/winreg_plugins/mrulist.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winreg_plugins/mrulistex.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/parsers/winreg_plugins/outlook.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winreg_plugins/services.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winreg_plugins/terminal_server.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winreg_plugins/test_lib.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/parsers/winreg_plugins/timezone.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winreg_plugins/winrar.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winreg_plugins/winver.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/preprocessors/windows.py View 1 4 chunks +4 lines, -4 lines 0 comments Download
D tests/winreg/__init__.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/winreg/cache.py View 1 1 chunk +0 lines, -35 lines 0 comments Download
M tests/winreg/test_lib.py View 1 1 chunk +0 lines, -204 lines 0 comments Download
M tests/winreg/winpyregf.py View 1 1 chunk +0 lines, -41 lines 0 comments Download
D tests/winreg/winregistry.py View 1 2 3 1 chunk +0 lines, -24 lines 0 comments Download
A + tests/winregistry/__init__.py View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/winregistry/cache.py View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + tests/winregistry/test_lib.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + tests/winregistry/winpyregf.py View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + tests/winregistry/winregistry.py View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M tools/preg.py View 1 2 3 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 14
Joachim Metz
8 years, 8 months ago (2015-07-08 08:38:48 UTC) #1
Joachim Metz
https://codereview.appspot.com/255830043/diff/1/plaso/frontend/preg.py File plaso/frontend/preg.py (right): https://codereview.appspot.com/255830043/diff/1/plaso/frontend/preg.py#newcode694 plaso/frontend/preg.py:694: self._win_registry = winregistry.WinRegistry( TODO pass code page
8 years, 8 months ago (2015-07-08 08:44:36 UTC) #2
Joachim Metz
Code updated.
8 years, 8 months ago (2015-07-13 06:26:13 UTC) #3
Joachim Metz
Code updated.
8 years, 8 months ago (2015-07-13 07:01:41 UTC) #4
kiddi
Few comments https://codereview.appspot.com/255830043/diff/40001/plaso/frontend/preg.py File plaso/frontend/preg.py (right): https://codereview.appspot.com/255830043/diff/40001/plaso/frontend/preg.py#newcode804 plaso/frontend/preg.py:804: # is unclear what the actual role ...
8 years, 8 months ago (2015-07-23 21:03:02 UTC) #5
Joachim Metz
https://codereview.appspot.com/255830043/diff/40001/plaso/frontend/preg.py File plaso/frontend/preg.py (right): https://codereview.appspot.com/255830043/diff/40001/plaso/frontend/preg.py#newcode804 plaso/frontend/preg.py:804: # is unclear what the actual role of the ...
8 years, 8 months ago (2015-07-24 04:34:55 UTC) #6
Joachim Metz
Code updated.
8 years, 8 months ago (2015-07-24 04:37:42 UTC) #7
kiddi
minor comments left. have you tested this and it does not brake anything? or just ...
8 years, 8 months ago (2015-07-24 17:27:42 UTC) #8
Joachim Metz
> have you tested this and it does not brake anything? > or just tested ...
8 years, 8 months ago (2015-07-30 05:27:07 UTC) #9
Joachim Metz
Regarding end-to-end testing: https://github.com/log2timeline/plaso/issues/280
8 years, 8 months ago (2015-07-30 05:27:42 UTC) #10
Joachim Metz
https://codereview.appspot.com/255830043/diff/40001/plaso/winregistry/cache.py File plaso/winregistry/cache.py (right): https://codereview.appspot.com/255830043/diff/40001/plaso/winregistry/cache.py#newcode7 plaso/winregistry/cache.py:7: Agree: "a" next step ;) https://codereview.appspot.com/255830043/diff/40001/plaso/winregistry/interface.py File plaso/winregistry/interface.py (right): ...
8 years, 8 months ago (2015-07-31 05:06:38 UTC) #11
Joachim Metz
Code updated.
8 years, 8 months ago (2015-07-31 05:31:40 UTC) #12
kiddi
LGTM, just that minor comment about a missing comment https://codereview.appspot.com/255830043/diff/80001/plaso/winregistry/registry.py File plaso/winregistry/registry.py (right): https://codereview.appspot.com/255830043/diff/80001/plaso/winregistry/registry.py#newcode114 plaso/winregistry/registry.py:114: ...
8 years, 8 months ago (2015-07-31 20:37:28 UTC) #13
Joachim Metz
8 years, 8 months ago (2015-08-02 08:12:53 UTC) #14
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b