Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14406)

Issue 255210043: Fix GIR warnings about XMLNode with g-ir-scanner (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 9 months ago by fujiwara
Modified:
8 years, 9 months ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Fix GIR warnings about XMLNode with g-ir-scanner Fix: ibusxml.h:62: Warning: IBus: ibus_xml_parse_file: return value: Unresolved type: 'XMLNode*' R=Shawn.P.Huang@gmail.com Committed: 05f112adaa743cda35265a79622fc373d2331428

Patch Set 1 #

Patch Set 2 : Moved macros out of G_BEGIN_DECLS. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -7 lines) Patch
M src/ibusxml.h View 1 3 chunks +30 lines, -5 lines 0 comments Download
M src/ibusxml.c View 2 chunks +21 lines, -2 lines 0 comments Download

Messages

Total messages: 3
fujiwara
8 years, 9 months ago (2015-07-15 10:47:43 UTC) #1
Peng
On 2015/07/15 10:47:43, fujiwara wrote: lgtm
8 years, 9 months ago (2015-07-15 14:14:22 UTC) #2
fujiwara
8 years, 9 months ago (2015-07-16 04:33:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
05f112adaa743cda35265a79622fc373d2331428 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b