Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(152)

Issue 253870043: i#1673: Port extension libraries to ARM: change drmgr predicate handling

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 8 months ago by zhaoqin
Modified:
8 years, 8 months ago
Reviewers:
bruening
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#1673: Port extension libraries to ARM: change drmgr predicate handling This CL changed how drmgr handles the instrumented code for predicated instrs. - remove the code that adds predicates for all inserted code before any predicated app instr in Thumb code ---------------

Patch Set 1 #

Total comments: 9

Patch Set 2 : final #

Patch Set 3 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -23 lines) Patch
M ext/drmgr/drmgr.h View 1 1 chunk +7 lines, -6 lines 0 comments Download
M ext/drmgr/drmgr.c View 1 2 2 chunks +4 lines, -17 lines 0 comments Download

Messages

Total messages: 8
zhaoqin
8 years, 8 months ago (2015-07-04 21:14:19 UTC) #1
bruening
On 2015/07/04 21:14:19, zhaoqin wrote: > This CL changed how drmgr handles the instrumented code ...
8 years, 8 months ago (2015-07-06 17:19:46 UTC) #2
bruening
Please explain *why* in the commit message and point at i#1723. LGTM https://codereview.appspot.com/253870043/diff/1/ext/drmgr/drmgr.c File ext/drmgr/drmgr.c ...
8 years, 8 months ago (2015-07-06 17:29:26 UTC) #3
zhaoqin
Commit log for latest patchset: --------------- i#1673: Port extension libraries to ARM: change drmgr predicate ...
8 years, 8 months ago (2015-07-06 20:29:08 UTC) #4
zhaoqin
https://codereview.appspot.com/253870043/diff/1/ext/drmgr/drmgr.c File ext/drmgr/drmgr.c (left): https://codereview.appspot.com/253870043/diff/1/ext/drmgr/drmgr.c#oldcode680 ext/drmgr/drmgr.c:680: instr_is_predicated(inst) && !instr_is_cbr(inst)) { On 2015/07/06 17:29:26, bruening wrote: ...
8 years, 8 months ago (2015-07-06 20:33:00 UTC) #5
bruening
https://codereview.appspot.com/253870043/diff/1/ext/drmgr/drmgr.c File ext/drmgr/drmgr.c (left): https://codereview.appspot.com/253870043/diff/1/ext/drmgr/drmgr.c#oldcode680 ext/drmgr/drmgr.c:680: instr_is_predicated(inst) && !instr_is_cbr(inst)) { On 2015/07/06 20:32:59, zhaoqin wrote: ...
8 years, 8 months ago (2015-07-06 20:47:22 UTC) #6
zhaoqin
On 2015/07/06 20:47:22, bruening wrote: > https://codereview.appspot.com/253870043/diff/1/ext/drmgr/drmgr.c > File ext/drmgr/drmgr.c (left): > > https://codereview.appspot.com/253870043/diff/1/ext/drmgr/drmgr.c#oldcode680 > ...
8 years, 8 months ago (2015-07-06 21:22:19 UTC) #7
zhaoqin
8 years, 8 months ago (2015-07-06 21:23:51 UTC) #8
Committed as
https://github.com/DynamoRIO/dynamorio/commit/cd311e545a606d83776f891cacd9ab8...

Final commit log: 
---------------
i#1673: Port extension libraries to ARM: change drmgr predicate handling

This CL changed how drmgr handles the instrumented code for predicated instrs.
- remove the code that adds predicates for all inserted code before any
  predicated app instr in Thumb code

Review-URL: https://codereview.appspot.com/253870043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b