Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1215)

Issue 253570044: Move brushing_state_controller from core/ to ui/ (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 8 months ago by beaudoin
Modified:
8 years, 8 months ago
Reviewers:
nduca, nduca(google)
CC:
tracing-review_chromium.org
Base URL:
https://github.com/google/trace-viewer@master
Visibility:
Public.

Description

Move brushing_state_controller from core/ to ui/ BUG=#1168 R=nduca@google.com Committed: https://chromium.googlesource.com/external/trace-viewer/+/0590dc6bfd3a007bec42bd5f8c01fcd5da9e5387

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -518 lines) Patch
M tracing/trace_viewer.gypi View 2 chunks +1 line, -1 line 0 comments Download
D tracing/tracing/core/brushing_state_controller.html View 1 chunk +0 lines, -305 lines 0 comments Download
D tracing/tracing/core/brushing_state_controller_test.html View 1 chunk +0 lines, -204 lines 0 comments Download
M tracing/tracing/ui/analysis/analysis_link.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/analysis_view_test.html View 2 chunks +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/memory_dump_overview_pane_test.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + tracing/tracing/ui/brushing_state_controller.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tracing/tracing/ui/brushing_state_controller_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/raster_task_view_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/timeline_view.html View 2 chunks +1 line, -1 line 0 comments Download
M tracing/tracing/ui/view_specific_brushing_state.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/view_specific_brushing_state_test.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
beaudoin
8 years, 8 months ago (2015-07-31 17:45:19 UTC) #1
beaudoin
On 2015/07/31 17:45:19, beaudoin wrote: Friendly ping. Feel free to reassign.
8 years, 8 months ago (2015-08-03 18:31:32 UTC) #2
nduca(google)
oh lgtm
8 years, 8 months ago (2015-08-03 18:49:57 UTC) #3
beaudoin
8 years, 8 months ago (2015-08-03 19:01:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0590dc6bfd3a007bec42bd5f8c01fcd5da9e5387 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b