Issue 250220043: i#1703 Cache Simulator: add predicates for tracer client

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 250220043: i#1703 Cache Simulator: add predicates for tracer client

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 9 months ago by zhaoqin

Modified:
8 years, 9 months ago

Reviewers:
bruening

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#1703 Cache Simulator: add predicates for tracer client This CL changed tracer to add predicates for memory tracing code on predciated app instructions so that memory reference is collected only if the predicate is true (i.e., app instr is executed). ---------------

Patch Set 1 #

Total comments: 3

Patch Set 2 : final #

Patch Set 3 : Committed #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -22 lines)			Patch
	M	clients/drcachesim/tracer/tracer.cpp	View	1 2	9 chunks	+62 lines, -22 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bruening

nit: commit message wording seems awkward, with grammar errors and odd past tense. nit: "Cache ...

8 years, 9 months ago (2015-07-07 17:32:26 UTC) #2

bruening

Has a bug but should be fixable w/o needing another look so LGTM w/ comments ...

8 years, 9 months ago (2015-07-07 21:51:42 UTC) #3

zhaoqin

Commit log for latest patchset: --------------- i#1703 Cache Simulator: add predicates for tracer client This ...

8 years, 9 months ago (2015-07-10 19:53:13 UTC) #4

zhaoqin

8 years, 9 months ago (2015-07-10 22:26:28 UTC) #5

Committed as
https://github.com/DynamoRIO/dynamorio/commit/8ff9051e78bedb33da16a5c766b6c48...

Final commit log: 
---------------
i#1703 Cache Simulator: add predicates for tracer client

This CL changed tracer to add predicates for memory tracing code on
predciated app instructions so that memory reference is collected
only if the predicate is true (i.e., app instr is executed).

Review-URL: https://codereview.appspot.com/250220043
---------------

Expand All Messages | Collapse All Messages