Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4158)

Issue 250170043: Issue 4475: Avoid treating x as relative in \relative { \autochange {x} } (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 9 months ago by Dan Eble
Modified:
8 years, 8 months ago
Reviewers:
Keith, thomasmorley651
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

This is important because the inner music is processed in multiple passes, not all of which are aware of the outer \relative. Add a regression test for this case and for \partcombine (which already worked as desired).

Patch Set 1 #

Patch Set 2 : Remove unnecessary context spec #

Total comments: 2

Patch Set 3 : Improve(?) regtests #

Patch Set 4 : Use Keith's test and improve partcombine test #

Patch Set 5 : rebase and fix texinfo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -4 lines) Patch
A input/regression/autochange-relative.ly View 1 2 3 4 1 chunk +17 lines, -0 lines 0 comments Download
A input/regression/part-combine-relative.ly View 1 2 3 4 1 chunk +17 lines, -0 lines 0 comments Download
M scm/autochange.scm View 1 2 3 4 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 10
Dan Eble
8 years, 9 months ago (2015-07-03 00:46:02 UTC) #1
Dan Eble
Remove unnecessary context spec
8 years, 9 months ago (2015-07-03 01:43:16 UTC) #2
thomasmorley651
Looks like it's now consistent with the NR saying: "A \relative section that is outside ...
8 years, 9 months ago (2015-07-03 10:29:05 UTC) #3
Keith
\relative does its job just fine on the output of \autochange and \partcombine. The only ...
8 years, 9 months ago (2015-07-04 04:34:01 UTC) #4
Dan Eble
On 2015/07/04 04:34:01, Keith wrote: > These are strange regression tests, in that they test ...
8 years, 9 months ago (2015-07-04 12:45:04 UTC) #5
Dan Eble
Improve(?) regtests
8 years, 9 months ago (2015-07-04 14:03:57 UTC) #6
Keith
On Sat, 04 Jul 2015 05:45:04 -0700, <nine.fierce.ballads@gmail.com> wrote: > Nobody knew \autochange was broken ...
8 years, 9 months ago (2015-07-04 18:08:16 UTC) #7
Dan Eble
Use Keith's test and improve partcombine test
8 years, 8 months ago (2015-07-06 16:19:19 UTC) #8
Dan Eble
8 years, 8 months ago (2015-07-11 23:21:04 UTC) #9
Dan Eble
8 years, 8 months ago (2015-07-12 00:38:44 UTC) #10
rebase and fix texinfo
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b