Clean up of Mac OS X preprocessor plugins #155.

Clean up of Mac OS X preprocessor plugins #155.

[Joachim Metz, 2015-07-04 13:23:03]

https://codereview.appspot.com/249540043/diff/1/plaso/lib/plist.py
File plaso/lib/plist.py (right):

https://codereview.appspot.com/249540043/diff/1/plaso/lib/plist.py#newcode1
plaso/lib/plist.py:1: # -*- coding: utf-8 -*-
add test

https://codereview.appspot.com/249540043/diff/1/plaso/preprocessors/macosx.py
File plaso/preprocessors/macosx.py (right):

https://codereview.appspot.com/249540043/diff/1/plaso/preprocessors/macosx.py...
plaso/preprocessors/macosx.py:295: u'realname': match.get('urealname',
[u'N/A'])[0]}
u'realname'

[kiddi, 2015-07-05 00:51:30]

Few comments

https://codereview.appspot.com/249540043/diff/1/plaso/preprocessors/macosx.py
File plaso/preprocessors/macosx.py (right):

https://codereview.appspot.com/249540043/diff/1/plaso/preprocessors/macosx.py...
plaso/preprocessors/macosx.py:19: # pylint: disable=abstract-method
can we have a comment on why this is needed? (due to the parent class being an
interface and this class is not meant to fully implement it, etc../

https://codereview.appspot.com/249540043/diff/1/plaso/preprocessors/macosx.py...
plaso/preprocessors/macosx.py:23: 
and returns the root key?

This function is called OpenFileEntry yet it not only opens it, it also returns
back the root key.... should that be the case? Or should it just save the plist
file or the root key in a instance attribute?

Or should the function be something like GetPlistRootKeyFromFileEntry

https://codereview.appspot.com/249540043/diff/1/plaso/preprocessors/macosx.py...
plaso/preprocessors/macosx.py:77: for name, subkey in key.iteritems():
iter(key.items())

https://codereview.appspot.com/249540043/diff/1/plaso/preprocessors/macosx.py...
plaso/preprocessors/macosx.py:295: u'realname': match.get('urealname',
[u'N/A'])[0]}
On 2015/07/04 13:23:03, Joachim Metz wrote:
> u'realname'

yes...

[Joachim Metz, 2015-07-05 05:07:10]

https://codereview.appspot.com/249540043/diff/1/plaso/preprocessors/macosx.py
File plaso/preprocessors/macosx.py (right):

https://codereview.appspot.com/249540043/diff/1/plaso/preprocessors/macosx.py...
plaso/preprocessors/macosx.py:77: for name, subkey in key.iteritems():
On 2015/07/05 00:51:30, kiddi wrote:
> iter(key.items())

No this is not a dict, but plistlib._InternalDict

[Joachim Metz, 2015-07-07 07:09:24]

https://codereview.appspot.com/249540043/diff/1/plaso/preprocessors/macosx.py
File plaso/preprocessors/macosx.py (right):

https://codereview.appspot.com/249540043/diff/1/plaso/preprocessors/macosx.py...
plaso/preprocessors/macosx.py:19: # pylint: disable=abstract-method
On 2015/07/05 00:51:30, kiddi wrote:
> can we have a comment on why this is needed? (due to the parent class being an
> interface and this class is not meant to fully implement it, etc../

It is likely better just to clean up the interface.

https://codereview.appspot.com/249540043/diff/1/plaso/preprocessors/macosx.py...
plaso/preprocessors/macosx.py:23: 
On 2015/07/05 00:51:30, kiddi wrote:
> and returns the root key?
> 
> This function is called OpenFileEntry yet it not only opens it, it also
returns
> back the root key.... should that be the case? Or should it just save the
plist
> file or the root key in a instance attribute?
> 
> Or should the function be something like GetPlistRootKeyFromFileEntry

Acknowledged.

[Joachim Metz, 2015-07-07 08:19:10]

Code updated.

[kiddi, 2015-07-31 20:47:23]

LGTM, one minor comment about a comments location

https://codereview.appspot.com/249540043/diff/20001/plaso/lib/plist.py
File plaso/lib/plist.py (right):

https://codereview.appspot.com/249540043/diff/20001/plaso/lib/plist.py#newcode51
plaso/lib/plist.py:51: # Note that binplist.readPlist does not seek to offset 0.
should this comment not be before the seek to zero?

[Joachim Metz, 2015-08-01 06:34:09]

Ack though I need to add a test as well.

[Joachim Metz, 2015-08-04 05:53:21]

Code updated.

[Joachim Metz, 2015-08-04 05:54:58]

I've added the test, please have a look at the latest additions

[Joachim Metz, 2015-08-04 19:33:50]

Code updated.

[kiddi, 2015-08-20 02:19:52]

Still LGTM