Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(28)

Issue 2473041: code review 2473041: misc: add goplay (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 1 month ago by adg
Modified:
5 days, 21 hours ago
Reviewers:
r, rsc
CC:
rsc, r, golang-dev
Visibility:
Public.

Description

misc: add goplay

Patch Set 1 #

Patch Set 2 : code review 2473041: misc: add goplay #

Total comments: 4

Patch Set 3 : code review 2473041: misc: add goplay #

Patch Set 4 : code review 2473041: misc: add goplay #

Total comments: 26

Patch Set 5 : code review 2473041: misc: add goplay #

Total comments: 4

Patch Set 6 : code review 2473041: misc: add goplay #

Total comments: 4

Patch Set 7 : code review 2473041: misc: add goplay #

Total comments: 4

Patch Set 8 : code review 2473041: misc: add goplay #

Patch Set 9 : code review 2473041: misc: add goplay #

Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -0 lines) Patch
A misc/goplay/Makefile View 1 chunk +13 lines, -0 lines 0 comments Download
A misc/goplay/README View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A misc/goplay/doc.go View 1 chunk +25 lines, -0 lines 0 comments Download
A misc/goplay/goplay.go View 1 2 3 4 5 6 7 1 chunk +305 lines, -0 lines 0 comments Download

Messages

Total messages: 17
adg
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
8 years, 1 month ago (2010-10-13 04:13:13 UTC) #1
rsc
Should probably have a short README.
8 years, 1 month ago (2010-10-13 04:39:35 UTC) #2
adg
Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.
8 years, 1 month ago (2010-10-13 05:02:38 UTC) #3
r
http://codereview.appspot.com/2473041/diff/4001/misc/goplay/README File misc/goplay/README (right): http://codereview.appspot.com/2473041/diff/4001/misc/goplay/README#newcode9 misc/goplay/README:9: and load http://localhost:3999/ in a web browser. Chrome and ...
8 years, 1 month ago (2010-10-13 05:09:35 UTC) #4
adg
PTAL http://codereview.appspot.com/2473041/diff/4001/misc/goplay/README File misc/goplay/README (right): http://codereview.appspot.com/2473041/diff/4001/misc/goplay/README#newcode9 misc/goplay/README:9: and load http://localhost:3999/ in a web browser. Chrome ...
8 years, 1 month ago (2010-10-13 05:34:08 UTC) #5
r
http://codereview.appspot.com/2473041/diff/13001/misc/goplay/README File misc/goplay/README (right): http://codereview.appspot.com/2473041/diff/13001/misc/goplay/README#newcode1 misc/goplay/README:1: Goplay is a web interface for experimenting with Go ...
8 years, 1 month ago (2010-10-13 05:50:20 UTC) #6
adg
http://codereview.appspot.com/2473041/diff/13001/misc/goplay/README File misc/goplay/README (right): http://codereview.appspot.com/2473041/diff/13001/misc/goplay/README#newcode1 misc/goplay/README:1: Goplay is a web interface for experimenting with Go ...
8 years, 1 month ago (2010-10-13 06:10:49 UTC) #7
adg
Hello rsc, r (cc: golang-dev@googlegroups.com), Please take another look.
8 years, 1 month ago (2010-10-13 06:10:50 UTC) #8
rsc1
http://codereview.appspot.com/2473041/diff/11005/misc/goplay/goplay.go File misc/goplay/goplay.go (right): http://codereview.appspot.com/2473041/diff/11005/misc/goplay/goplay.go#newcode22 misc/goplay/goplay.go:22: goarch = flag.String("goarch", "", "target architecture (defaults to environment)") ...
8 years, 1 month ago (2010-10-13 16:43:59 UTC) #9
adg
http://codereview.appspot.com/2473041/diff/11005/misc/goplay/goplay.go File misc/goplay/goplay.go (right): http://codereview.appspot.com/2473041/diff/11005/misc/goplay/goplay.go#newcode22 misc/goplay/goplay.go:22: goarch = flag.String("goarch", "", "target architecture (defaults to environment)") ...
8 years, 1 month ago (2010-10-13 23:16:00 UTC) #10
rsc1
http://codereview.appspot.com/2473041/diff/22001/misc/goplay/goplay.go File misc/goplay/goplay.go (right): http://codereview.appspot.com/2473041/diff/22001/misc/goplay/goplay.go#newcode30 misc/goplay/goplay.go:30: archChar = "6" // amd64 by default var archChar, ...
8 years, 1 month ago (2010-10-14 00:15:52 UTC) #11
adg
Hello rsc, r (cc: golang-dev@googlegroups.com), Please take another look.
8 years, 1 month ago (2010-10-14 00:24:23 UTC) #12
adg
http://codereview.appspot.com/2473041/diff/22001/misc/goplay/goplay.go File misc/goplay/goplay.go (right): http://codereview.appspot.com/2473041/diff/22001/misc/goplay/goplay.go#newcode30 misc/goplay/goplay.go:30: archChar = "6" // amd64 by default On 2010/10/14 ...
8 years, 1 month ago (2010-10-14 00:26:16 UTC) #13
r
LGTM but wait for rsc http://codereview.appspot.com/2473041/diff/15003/misc/goplay/goplay.go File misc/goplay/goplay.go (right): http://codereview.appspot.com/2473041/diff/15003/misc/goplay/goplay.go#newcode45 misc/goplay/goplay.go:45: log.Exit("unrecognized GOARCH:", runtime.GOARCH) s/:/: ...
8 years, 1 month ago (2010-10-14 00:29:06 UTC) #14
adg
http://codereview.appspot.com/2473041/diff/15003/misc/goplay/goplay.go File misc/goplay/goplay.go (right): http://codereview.appspot.com/2473041/diff/15003/misc/goplay/goplay.go#newcode45 misc/goplay/goplay.go:45: log.Exit("unrecognized GOARCH:", runtime.GOARCH) On 2010/10/14 00:29:06, r wrote: > ...
8 years, 1 month ago (2010-10-14 00:34:29 UTC) #15
rsc
LGTM
8 years, 1 month ago (2010-10-14 02:01:19 UTC) #16
adg
8 years, 1 month ago (2010-10-14 03:06:07 UTC) #17
*** Submitted as http://code.google.com/p/go/source/detail?r=980f30fafac2 ***

misc: add goplay

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/2473041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b