Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(18)

Issue 246010043: Do not put lookup window at the minus position (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 10 months ago by fujiwara
Modified:
8 years, 10 months ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Do not put lookup window at the minus position tweetdeck.twitter.com seems has hidden GdkWindow and does not provide the positive cursor position. BUG=https://github.com/ibus/ibus/issues/1801 Committed: bd7673e73c2a8c54d2a827603a960d76dab7be1b

Patch Set 1 #

Patch Set 2 : Reformat #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ui/gtk3/candidatepanel.vala View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3
fujiwara
8 years, 10 months ago (2015-06-11 09:26:03 UTC) #1
Peng
lgtm
8 years, 10 months ago (2015-06-11 14:56:28 UTC) #2
fujiwara
8 years, 10 months ago (2015-06-12 02:44:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
bd7673e73c2a8c54d2a827603a960d76dab7be1b (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b