Issue 245700044: FN v3: Move ACL processing out of the Permissions constructor

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 245700044: FN v3: Move ACL processing out of the Permissions constructor (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 9 months ago by JohnL

Modified:
8 years, 9 months ago

Reviewers:
brett.michael.johnson, Brett

CC:
connector-cr_google.com

Visibility:
Public.

More Reviews

Description

Move ACL processing out of the Permissions constructor. This is to avoid processing ACLs unnecessarily during authZ. The authZ and ACL facets of the Permissions class share very little, and could have been split, but I preferred keeping authorize and processPermissions together, since their logic is similar. Create an inner Acl class to hold the ACL multimaps.

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+84 lines, -72 lines)			Patch
M	projects_v4/filenet/source/java/com/google/enterprise/connector/filenet4/FileDocument.java	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	projects_v4/filenet/source/java/com/google/enterprise/connector/filenet4/Permissions.java	View	2 chunks	+61 lines, -50 lines	0 comments	Download
M	projects_v4/filenet/source/java/com/google/enterprise/connector/filenet4/SecurityFolderTraverser.java	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	projects_v4/filenet/source/java/com/google/enterprise/connector/filenet4/SecurityPolicyTraverser.java	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	projects_v4/filenet/source/javatests/com/google/enterprise/connector/filenet4/PermissionsTest.java	View	14 chunks	+15 lines, -15 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

JohnL

8 years, 9 months ago (2015-07-06 00:23:27 UTC) #3

Committed:
https://github.com/googlegsa/filenet.v3/commit/902788d4a690ffb938367fa43af76a...

John L

Expand All Messages | Collapse All Messages