Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(44)

Issue 245560043: Changes in User Setting and common.js to support highlighting of current links in menu

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 1 month ago by yask123
Modified:
2 years, 1 month ago
Reviewers:
ajgupta93, waldi, RogerHaase
Visibility:
Public.

Description

Changes in User Setting and common.js to support highlighting of current links in menu # Added common.css # Current opened tab now highlights in menu # Various css rules written to work on top/with common.css # Fixed the issue 'jumping of footer while changing tabs in user setting' # Fixed issue with breadcrumbs when the location address gets too long.

Patch Set 1 #

Patch Set 2 : Fixed footer jump while changing tabs in user setting in basic theme #

Patch Set 3 : minor enhancements to subscription box like fixed height with scroll and border of 1px http://i.img… #

Patch Set 4 : Fixed breadcrumbs, now even if address is large it won't push other elements of navbar #

Patch Set 5 : Fixed few HTML validation warnings due to 'role' attribute #

Patch Set 6 : Minor formatting changes and added comment #

Patch Set 7 : Fixed design break issue in Basic theme's subscription box: http://i.imgur.com/4s1CIb3.png #

Patch Set 8 : Fixed design break in small resolution and removed form from under 'ul' #

Patch Set 9 : Fixed the missing <div> error in global_history.html (HTML Validation) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M MoinMoin/themes/modernized/templates/global_history.html View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -1 line 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted