code review 24550043: gosshnew/ssh: fix connection leak in TestClientAuthInva...

gosshnew/ssh: fix connection leak in TestClientAuthInvalidPublicKey.

[hanwen-google, 2013-11-11 17:02:29]

Hello agl1, dfc, jpsugar@google.com (cc: agl@golang.org, dave@cheney.net,
golang-dev@googlegroups.com, hanwen@google.com),

I'd like you to review this change to
https://hanwen%40google.com@code.google.com/p/gosshnew/

[jpsugar, 2013-11-11 18:48:17]

https://codereview.appspot.com/24550043/diff/40001/ssh/client_auth_test.go
File ssh/client_auth_test.go (right):

https://codereview.appspot.com/24550043/diff/40001/ssh/client_auth_test.go#ne...
ssh/client_auth_test.go:185: defer c.Close()
How about just moving this up above c.Handshake?

[hanwen-google, 2013-11-12 14:44:42]

https://codereview.appspot.com/24550043/diff/40001/ssh/client_auth_test.go
File ssh/client_auth_test.go (right):

https://codereview.appspot.com/24550043/diff/40001/ssh/client_auth_test.go#ne...
ssh/client_auth_test.go:185: defer c.Close()
On 2013/11/11 18:48:17, jpsugar wrote:
> How about just moving this up above c.Handshake?

Done.

[agl1, 2013-11-12 15:40:26]

LGTM

[hanwen-google, 2013-11-12 15:42:02]

*** Submitted as https://code.google.com/p/gosshnew/source/detail?r=e6786074259a
***

gosshnew/ssh: fix connection leak in TestClientAuthInvalidPublicKey.

R=agl, dave, jpsugar
CC=agl, dave, golang-dev, hanwen, jpsugar
https://codereview.appspot.com/24550043