Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(106)

Issue 24550043: code review 24550043: gosshnew/ssh: fix connection leak in TestClientAuthInva... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 2 months ago by hanwen-google
Modified:
8 years, 2 months ago
Reviewers:
agl1
CC:
agl1, dfc, jpsugar, golang-dev, hanwen-google
Visibility:
Public.

Description

gosshnew/ssh: fix connection leak in TestClientAuthInvalidPublicKey.

Patch Set 1 #

Patch Set 2 : diff -r e442b718b9b7 https://hanwen%40google.com@code.google.com/p/gosshnew/ #

Patch Set 3 : diff -r e442b718b9b7 https://hanwen%40google.com@code.google.com/p/gosshnew/ #

Total comments: 2

Patch Set 4 : diff -r c67209ba743e https://hanwen%40google.com@code.google.com/p/gosshnew/ #

Patch Set 5 : diff -r c67209ba743e https://hanwen%40google.com@code.google.com/p/gosshnew/ #

Patch Set 6 : diff -r 2498fa3a2813 https://hanwen%40google.com@code.google.com/p/gosshnew/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ssh/client_auth_test.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
hanwen-google
Hello agl1, dfc, jpsugar@google.com (cc: agl@golang.org, dave@cheney.net, golang-dev@googlegroups.com, hanwen@google.com), I'd like you to review this ...
8 years, 2 months ago (2013-11-11 17:02:29 UTC) #1
jpsugar
https://codereview.appspot.com/24550043/diff/40001/ssh/client_auth_test.go File ssh/client_auth_test.go (right): https://codereview.appspot.com/24550043/diff/40001/ssh/client_auth_test.go#newcode185 ssh/client_auth_test.go:185: defer c.Close() How about just moving this up above ...
8 years, 2 months ago (2013-11-11 18:48:17 UTC) #2
hanwen-google
https://codereview.appspot.com/24550043/diff/40001/ssh/client_auth_test.go File ssh/client_auth_test.go (right): https://codereview.appspot.com/24550043/diff/40001/ssh/client_auth_test.go#newcode185 ssh/client_auth_test.go:185: defer c.Close() On 2013/11/11 18:48:17, jpsugar wrote: > How ...
8 years, 2 months ago (2013-11-12 14:44:42 UTC) #3
agl1
LGTM
8 years, 2 months ago (2013-11-12 15:40:26 UTC) #4
hanwen-google
8 years, 2 months ago (2013-11-12 15:42:02 UTC) #5
*** Submitted as https://code.google.com/p/gosshnew/source/detail?r=e6786074259a
***

gosshnew/ssh: fix connection leak in TestClientAuthInvalidPublicKey.

R=agl, dave, jpsugar
CC=agl, dave, golang-dev, hanwen, jpsugar
https://codereview.appspot.com/24550043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b