Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(26)

Issue 245270044: Layout.html Bootstrapped

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 1 month ago by yask123
Modified:
2 years, 1 month ago
Reviewers:
waldi
Visibility:
Public.

Description

This is a rewrite of the `layout.html` template to work on top of Boostrap. It also replaces the old stylus theme by new modernized bootstrap theme. The theme is written in `theme.less` and `modernized.less` file. The rest of the .less files are Bootstrap's default less files. To test it on your machine: compile this file MoinMoin/themes/modernized/static/css/theme.less by lessc `$ lessc theme.less > ../css/ ` So the files to look for are: `theme.less` `layout.html` `modernized.less` Rest of the less files are from bootstrap source. Rest of the css files are compiled form of less files by lessc. #ChangeLog from patch #2 Fixed the alignment of sub menu tabs and item views tabs Added active visual effect to the current tab view Fixed horizontal scroll bug Fixed padding inside sub menu Increased font size for wiki contents Now the files to look for are : `theme.less` `layout.html` `modernized.less` 'common.js' Changelog #3 Now uses current bootstrap. Since changes for compiling modernized less file in `make.py` hasn't yet been made , follow these instructions to manually compile this theme. 1. Place the modernized theme less files (/Users/yask/final/moin-2.0/MoinMoin/themes/modernized/static/css/less/*) to (/moin-2.0-venv-python2.7/lib/python2.7/site-packages/xstatic/pkg/bootstrap/data/less/*) 2. Compile the `theme.less` to theme.css and place this in (moin-2.0/MoinMoin/themes/modernized/static/css/)

Patch Set 1 #

Patch Set 2 : updated cr #

Patch Set 3 : Using current bootstrap #

Patch Set 4 : Using old bootstrap v1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4633 lines, -407 lines) Patch
M MoinMoin/static/js/common.js View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M MoinMoin/templates/base.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M MoinMoin/templates/itemviews.html View 2 1 chunk +1 line, -1 line 0 comments Download
M MoinMoin/templates/layout.html View 1 2 2 chunks +116 lines, -109 lines 0 comments Download
M MoinMoin/templates/modify.html View 1 2 1 chunk +1 line, -3 lines 0 comments Download
A MoinMoin/themes/modernized/static/css/less/modernized.less View 1 2 3 chunks +1141 lines, -2 lines 0 comments Download
M MoinMoin/themes/modernized/static/css/theme.css View 1 2 2 chunks +3371 lines, -290 lines 0 comments Download

Messages

Total messages: 1
yask123
2 years, 1 month ago (2015-06-16 11:23:40 UTC) #1

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted