Issue 2444041: code review 2444041: Make.cmd: remove $(OFILES)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2444041: code review 2444041: Make.cmd: remove $(OFILES) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by ec

Modified:
13 years, 5 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

Make.cmd: remove $(OFILES) The linker doesn't support multiple object files (maybe it did in the past?)

Patch Set 1 #

Patch Set 2 : code review 2444041: Make.cmd: remove $(OFILES) #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/Make.cmd	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

13 years, 6 months ago (2010-10-12 02:31:58 UTC) #1

rsc1

LGTM Yes, to implement $(OFILES) in Make.cmd now you'd have to put the files in ...

13 years, 6 months ago (2010-10-12 02:37:23 UTC) #2

rsc

13 years, 6 months ago (2010-10-12 02:39:39 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=c7ad3c44c8b6 ***

Make.cmd: remove $(OFILES)

The linker doesn't support multiple object files (maybe it did in the past?)

R=rsc
CC=golang-dev
http://codereview.appspot.com/2444041

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages