Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(54)

Issue 2444041: code review 2444041: Make.cmd: remove $(OFILES) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 6 months ago by ec
Modified:
3 years, 5 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

Make.cmd: remove $(OFILES)

The linker doesn't support multiple object files (maybe it did in the past?)

Patch Set 1 #

Patch Set 2 : code review 2444041: Make.cmd: remove $(OFILES) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/Make.cmd View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
ec
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
3 years, 6 months ago #1
rsc1
LGTM Yes, to implement $(OFILES) in Make.cmd now you'd have to put the files in ...
3 years, 6 months ago #2
rsc
3 years, 6 months ago #3
*** Submitted as http://code.google.com/p/go/source/detail?r=c7ad3c44c8b6 ***

Make.cmd: remove $(OFILES)

The linker doesn't support multiple object files (maybe it did in the past?)

R=rsc
CC=golang-dev
http://codereview.appspot.com/2444041

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5