Issue 243890043: html content type with div is not rendered, fixes #157

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 243890043: html content type with div is not rendered, fixes #157 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 10 months ago by RogerHaase

Modified:
8 years, 10 months ago

Reviewers:

Visibility:
Public.

More Reviews

Description

html content type with div is not rendered, fixes #157

Patch Set 1 #

Total comments: 3

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -15 lines)			Patch
M	MoinMoin/converter/_tests/test_html_in.py	View	2 chunks	+15 lines, -7 lines	1 comment	Download
M	MoinMoin/converter/_tests/test_html_in_out.py	View	3 chunks	+6 lines, -6 lines	1 comment	Download
M	MoinMoin/converter/html_in.py	View	1 chunk	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

RogerHaase

Only newly broken tests were fixed. If lxml is installed on windows, there are 21 ...

8 years, 10 months ago (2015-06-01 04:13:03 UTC) #1

RogerHaase

8 years, 10 months ago (2015-06-06 18:49:55 UTC) #2

https://codereview.appspot.com/243890043/diff/1/MoinMoin/converter/html_in.py
File MoinMoin/converter/html_in.py (left):

https://codereview.appspot.com/243890043/diff/1/MoinMoin/converter/html_in.py...
MoinMoin/converter/html_in.py:106: if html_tree.tag.name != 'html' and
html_tree.tag.name != 'div':
deletion reverses c20b7349dfd7 from 2010-06-28. Per comment intent was to avoid
a div within a div. This obviously effects several tests with unusual input, but
could not find an instance while rendering a normal wiki page.

Expand All Messages | Collapse All Messages