Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(62)

Issue 2404: [PATCH] new hook chain for unhandled stanzas (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by Jacob
Modified:
12 years, 3 months ago
Reviewers:
dangabrad, Jacob, djabberd
Base URL:
http://code.sixapart.com/svn/djabberd/trunk/DJabberd
Visibility:
Public.

Description

I am working on a Djabberd plugin to support stream compression (http://www.xmpp.org/extensions/xep-0138.html). This requires handling a new type of stanza <compress ...> So, this patch introduces the hook "HandleStanza" which is called whenever the server receives a stanza that is not "iq", "presence", "message" or "starttls". Something in the hook chain must call the 'accept' callback to signify the class to use for the stanza downbless, otherwise.. we continue on to the existing behavior which is to return a stream error. ----- patch set 3 committed in http://code.sixapart.com/trac/djabberd/changeset/822

Patch Set 1 #

Patch Set 2 : fix to issues brad raised about patch set 1. #

Patch Set 3 : Code review tool couldn't parse my last patch, trying again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
lib/DJabberd/Connection/ClientIn.pm View 1 2 1 chunk +13 lines, -3 lines 0 comments Download
lib/DJabberd/HookDocs.pm View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3
dangabrad
http://codereview.appspot.com/2404/diff/1/3 File lib/DJabberd/Connection/ClientIn.pm (right): http://codereview.appspot.com/2404/diff/1/3#newcode208 Line 208: my $class = $element2class{$node->element} uh, missing a semicolon? ...
13 years, 4 months ago (2008-06-27 05:54:06 UTC) #1
Jacob
fix to issues brad raised about patch set 1.
12 years, 11 months ago (2008-11-03 19:33:47 UTC) #2
Jacob
12 years, 11 months ago (2008-11-03 19:38:09 UTC) #3
Code review tool couldn't parse my last patch, trying again
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b