DCTM v3: Add tests for required groups and group sets

Add tests for required groups and group sets.

Add support for H2 in MockDmSession.getObject while preserving the use
of JCR for legacy tests. Change MockDmAcl ID values from ints to
strings, while preserving the existing constructor as an overload to
avoid gratuitous changes in the existing tests.

Related changes:

* Make MockDmQuery.executeQuery public to create a real DctmAclList
  with an ICollection. This is short of creating the DctmAclList from
  DctmTraversalManager, but it's a start.

* Filter out evil ACL entries with Read access but not AccessPermit,
  already fixed in v4.

Other changes:

* Remove javadoc tag for unthrown exception, also already fixed in v4.

[Brett, 2015-05-10 00:24:55]

LGTM

https://codereview.appspot.com/238080043/diff/1/projects/dctm-core/source/jav...
File
projects/dctm-core/source/javatests/com/google/enterprise/connector/dctm/DctmMockAclListTest.java
(right):

https://codereview.appspot.com/238080043/diff/1/projects/dctm-core/source/jav...
projects/dctm-core/source/javatests/com/google/enterprise/connector/dctm/DctmMockAclListTest.java:202:

delete blank line

https://codereview.appspot.com/238080043/diff/1/projects/dctm-core/source/jav...
File
projects/dctm-core/source/javatests/com/google/enterprise/connector/dctm/dctmmockwrap/MockDmQuery.java
(right):

https://codereview.appspot.com/238080043/diff/1/projects/dctm-core/source/jav...
projects/dctm-core/source/javatests/com/google/enterprise/connector/dctm/dctmmockwrap/MockDmQuery.java:156:
throws RepositoryException {
Didn't need to break line.

[Brett, 2015-05-10 04:05:18]

https://codereview.appspot.com/238080043/diff/1/projects/dctm-core/source/jav...
File
projects/dctm-core/source/javatests/com/google/enterprise/connector/dctm/dctmmockwrap/MockDmSession.java
(right):

https://codereview.appspot.com/238080043/diff/1/projects/dctm-core/source/jav...
projects/dctm-core/source/javatests/com/google/enterprise/connector/dctm/dctmmockwrap/MockDmSession.java:126:
String table = objectTypes.get(id.substring(0, 2));
Add toUpper() or toLower() for appropriate Hex digits?

[JohnL, 2015-05-12 02:46:45]

Brett's code review comments

[JohnL, 2015-05-12 02:47:26]

Handling Brett's comments.

John L

https://codereview.appspot.com/238080043/diff/1/projects/dctm-core/source/jav...
File
projects/dctm-core/source/javatests/com/google/enterprise/connector/dctm/DctmMockAclListTest.java
(right):

https://codereview.appspot.com/238080043/diff/1/projects/dctm-core/source/jav...
projects/dctm-core/source/javatests/com/google/enterprise/connector/dctm/DctmMockAclListTest.java:202:

On 2015/05/10 00:24:55, Brett wrote:
> delete blank line

Done.

https://codereview.appspot.com/238080043/diff/1/projects/dctm-core/source/jav...
File
projects/dctm-core/source/javatests/com/google/enterprise/connector/dctm/dctmmockwrap/MockDmQuery.java
(right):

https://codereview.appspot.com/238080043/diff/1/projects/dctm-core/source/jav...
projects/dctm-core/source/javatests/com/google/enterprise/connector/dctm/dctmmockwrap/MockDmQuery.java:156:
throws RepositoryException {
On 2015/05/10 00:24:55, Brett wrote:
> Didn't need to break line.

Done.

https://codereview.appspot.com/238080043/diff/1/projects/dctm-core/source/jav...
File
projects/dctm-core/source/javatests/com/google/enterprise/connector/dctm/dctmmockwrap/MockDmSession.java
(right):

https://codereview.appspot.com/238080043/diff/1/projects/dctm-core/source/jav...
projects/dctm-core/source/javatests/com/google/enterprise/connector/dctm/dctmmockwrap/MockDmSession.java:126:
String table = objectTypes.get(id.substring(0, 2));
On 2015/05/10 04:05:18, Brett wrote:
> Add toUpper() or toLower() for appropriate Hex digits?

Done. Also match hex digits instead of decimal digits in the pattern above. I
stuck with the real-ish, that is, I don't require a 16-character hex string,
just a string starting with two hex digits. There is more potential ambiguity
with the hex digits, but the existing legacy values are "users" and "doc1"
through "doc26".

[JohnL, 2015-05-12 06:16:22]

Fix compilation error

[Brett, 2015-05-12 17:34:51]

LGTM

[Srinivas, 2015-05-27 01:46:32]

On 2015/05/12 17:34:51, Brett wrote:
> LGTM

LGTM

[JohnL, 2015-05-29 06:20:58]

Committed:
https://github.com/googlegsa/documentum.v3/commit/67111b551a8fa9e95c1b8bad241...

John L