Issue 235930043: NTFS and ADS support #13

Issue 235930043: NTFS and ADS support #13 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 11 months ago by Joachim Metz

Modified:
8 years, 7 months ago

Reviewers:
kiddi, onager

CC:
log2timeline-dev_googlegroups.com

Visibility:
Public.

More Reviews

Patch Set 2 : Small changes. #

Total comments: 14

Patch Set 3 : Added file IO ADS tests. #

Total comments: 4

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2660 lines, -247 lines)			Patch
M	.travis.yml	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	appveyor.yml	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	config/dpkg/control	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	dfvfs/analyzer/__init__.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	dfvfs/analyzer/analyzer.py	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	dfvfs/analyzer/analyzer_helper.py	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
A	dfvfs/analyzer/ntfs_analyzer_helper.py	View	1	1 chunk	+38 lines, -0 lines	0 comments	Download
M	dfvfs/analyzer/tsk_analyzer_helper.py	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	dfvfs/dependencies.py	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	dfvfs/file_io/file_object_io.py	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	dfvfs/file_io/ntfs_file_io.py	View	1	9 chunks	+49 lines, -26 lines	0 comments	Download
M	dfvfs/file_io/tsk_file_io.py	View	1	5 chunks	+45 lines, -13 lines	0 comments	Download
M	dfvfs/helpers/source_scanner.py	View	1	1 chunk	+12 lines, -3 lines	0 comments	Download
M	dfvfs/lib/date_time.py	View		2 chunks	+99 lines, -32 lines	0 comments	Download
M	dfvfs/lib/definitions.py	View	1	3 chunks	+5 lines, -0 lines	0 comments	Download
M	dfvfs/path/__init__.py	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	dfvfs/path/factory.py	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	dfvfs/path/ntfs_path_spec.py	View		1 chunk	+64 lines, -0 lines	0 comments	Download
M	dfvfs/proto/transmission.proto	View	1	2 chunks	+10 lines, -1 line	0 comments	Download
M	dfvfs/proto/transmission_pb2.py	View	1	4 chunks	+25 lines, -4 lines	0 comments	Download
M	dfvfs/resolver/__init__.py	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
A +	dfvfs/resolver/ntfs_resolver_helper.py	View	1	3 chunks	+9 lines, -9 lines	0 comments	Download
M	dfvfs/vfs/bde_file_entry.py	View		1 chunk	+5 lines, -3 lines	0 comments	Download
M	dfvfs/vfs/fake_file_entry.py	View	1	2 chunks	+13 lines, -2 lines	0 comments	Download
M	dfvfs/vfs/fake_file_system.py	View	1	1 chunk	+10 lines, -5 lines	0 comments	Download
M	dfvfs/vfs/file_entry.py	View	1	5 chunks	+143 lines, -4 lines	0 comments	Download
A	dfvfs/vfs/ntfs_file_entry.py	View	1 2	1 chunk	+433 lines, -0 lines	4 comments	Download
A	dfvfs/vfs/ntfs_file_system.py	View	1	1 chunk	+162 lines, -0 lines	0 comments	Download
M	dfvfs/vfs/os_file_entry.py	View	1	3 chunks	+20 lines, -3 lines	0 comments	Download
M	dfvfs/vfs/tar_file_entry.py	View	1	2 chunks	+16 lines, -1 line	0 comments	Download
M	dfvfs/vfs/tsk_file_entry.py	View	1 2	11 chunks	+196 lines, -53 lines	0 comments	Download
M	dfvfs/vfs/vshadow_file_entry.py	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download
M	dfvfs/vfs/zip_file_entry.py	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download
M	examples/recursive_hasher.py	View	1	2 chunks	+39 lines, -9 lines	0 comments	Download
M	examples/recursive_hasher2.py	View	1	4 chunks	+69 lines, -10 lines	0 comments	Download
M	tests/analyzer/analyzer.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A	tests/file_io/ntfs_file_io.py	View	1 2	1 chunk	+149 lines, -0 lines	0 comments	Download
M	tests/file_io/tsk_file_io.py	View	1 2	2 chunks	+33 lines, -0 lines	0 comments	Download
M	tests/helpers/source_scanner.py	View	1	2 chunks	+5 lines, -2 lines	0 comments	Download
A	tests/path/ntfs_path_spec.py	View		1 chunk	+118 lines, -0 lines	0 comments	Download
A +	tests/resolver/ntfs_resolver_helper.py	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	tests/vfs/bde_file_entry.py	View		1 chunk	+30 lines, -0 lines	0 comments	Download
M	tests/vfs/compressed_stream_file_entry.py	View		1 chunk	+32 lines, -0 lines	0 comments	Download
M	tests/vfs/fake_file_entry.py	View	1	9 chunks	+66 lines, -2 lines	0 comments	Download
M	tests/vfs/gzip_file_entry.py	View		5 chunks	+32 lines, -2 lines	0 comments	Download
A	tests/vfs/ntfs_file_entry.py	View	1 2	1 chunk	+256 lines, -0 lines	0 comments	Download
A +	tests/vfs/ntfs_file_system.py	View	1	3 chunks	+30 lines, -26 lines	0 comments	Download
M	tests/vfs/os_file_entry.py	View	1	6 chunks	+47 lines, -5 lines	0 comments	Download
M	tests/vfs/tar_file_entry.py	View		6 chunks	+51 lines, -1 line	0 comments	Download
M	tests/vfs/tsk_file_entry.py	View	1	9 chunks	+148 lines, -3 lines	0 comments	Download
M	tests/vfs/tsk_partition_file_entry.py	View		5 chunks	+50 lines, -1 line	0 comments	Download
M	tests/vfs/vshadow_file_entry.py	View		6 chunks	+50 lines, -2 lines	0 comments	Download
M	tests/vfs/zip_file_entry.py	View	1	6 chunks	+50 lines, -2 lines	0 comments	Download
M	utils/run_linter.sh	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 13

Expand All Messages | Collapse All Messages

kiddi

Have not gone through all the files, but so far looks pretty good. But since ...

8 years, 11 months ago (2015-05-07 10:31:56 UTC) #2

Joachim Metz

https://codereview.appspot.com/235930043/diff/1/dfvfs/vfs/ntfs_file_entry.py File dfvfs/vfs/ntfs_file_entry.py (right): https://codereview.appspot.com/235930043/diff/1/dfvfs/vfs/ntfs_file_entry.py#newcode161 dfvfs/vfs/ntfs_file_entry.py:161: # TODO: implement. On 2015/05/07 10:31:55, kiddi wrote: > ...

8 years, 11 months ago (2015-05-10 19:12:25 UTC) #3

kiddi

Few comments I am assuming this CL is now ready? https://codereview.appspot.com/235930043/diff/100001/dfvfs/vfs/ntfs_file_entry.py File dfvfs/vfs/ntfs_file_entry.py (right): https://codereview.appspot.com/235930043/diff/100001/dfvfs/vfs/ntfs_file_entry.py#newcode148 ...

8 years, 7 months ago (2015-08-31 21:32:46 UTC) #9

Joachim Metz

https://codereview.appspot.com/235930043/diff/100001/dfvfs/vfs/ntfs_file_entry.py File dfvfs/vfs/ntfs_file_entry.py (right): https://codereview.appspot.com/235930043/diff/100001/dfvfs/vfs/ntfs_file_entry.py#newcode148 dfvfs/vfs/ntfs_file_entry.py:148: BackEndError: when the pyfsntfs file entry is missing. On ...

8 years, 7 months ago (2015-09-01 07:37:40 UTC) #10

kiddi

LGTM only one minor comment (appears twice) https://codereview.appspot.com/235930043/diff/120001/dfvfs/vfs/ntfs_file_entry.py File dfvfs/vfs/ntfs_file_entry.py (right): https://codereview.appspot.com/235930043/diff/120001/dfvfs/vfs/ntfs_file_entry.py#newcode82 dfvfs/vfs/ntfs_file_entry.py:82: fsntfs_sub_file_entry.file_reference & ...

8 years, 7 months ago (2015-09-14 23:01:56 UTC) #12

Joachim Metz

8 years, 7 months ago (2015-09-15 05:11:03 UTC) #13

https://codereview.appspot.com/235930043/diff/120001/dfvfs/vfs/ntfs_file_entr...
File dfvfs/vfs/ntfs_file_entry.py (right):

https://codereview.appspot.com/235930043/diff/120001/dfvfs/vfs/ntfs_file_entr...
dfvfs/vfs/ntfs_file_entry.py:82: fsntfs_sub_file_entry.file_reference &
0xffffffffffff)
On 2015/09/14 23:01:55, kiddi wrote:
> should this be a constant? instead of 0xff.....

Done.

https://codereview.appspot.com/235930043/diff/120001/dfvfs/vfs/ntfs_file_entr...
dfvfs/vfs/ntfs_file_entry.py:416: parent_mft_entry = parent_file_reference &
0xffffffffffff
On 2015/09/14 23:01:55, kiddi wrote:
> used again here, have this as a class constant

Done.

Expand All Messages | Collapse All Messages