rework global history styling for modernized and basic themes, add user and comment fields, partial

rework global history styling for modernized and basic themes, add user and comment fields, partial fix #471

[RogerHaase, 2015-04-26 04:16:39]

https://codereview.appspot.com/235720043/diff/1/MoinMoin/static/css/common.css
File MoinMoin/static/css/common.css (right):

https://codereview.appspot.com/235720043/diff/1/MoinMoin/static/css/common.cs...
MoinMoin/static/css/common.css:388: .moin-history-links { width: .5em; }
add styling for global history to common.css so all themes have like styling of
content

https://codereview.appspot.com/235720043/diff/1/MoinMoin/templates/global_his...
File MoinMoin/templates/global_history.html (right):

https://codereview.appspot.com/235720043/diff/1/MoinMoin/templates/global_his...
MoinMoin/templates/global_history.html:64: <td class="moin-wordbreak
moin-history-comment">{{ rev.meta['comment'] }}</td>
Add comment and editor fields. Change order of fields so most important fields
(item name, editor,...) are on left. Sort changed items within a date by name.

https://codereview.appspot.com/235720043/diff/1/MoinMoin/themes/__init__.py
File MoinMoin/themes/__init__.py (right):

https://codereview.appspot.com/235720043/diff/1/MoinMoin/themes/__init__.py#n...
MoinMoin/themes/__init__.py:658: return
datetime.datetime.fromtimestamp(dt).strftime('%H:%M')
Saves 6 characters - time was displayed as 12:12:12 PM

https://codereview.appspot.com/235720043/diff/1/MoinMoin/themes/basic/static/...
File MoinMoin/themes/basic/static/css/theme.css (left):

https://codereview.appspot.com/235720043/diff/1/MoinMoin/themes/basic/static/...
MoinMoin/themes/basic/static/css/theme.css:6809: }
remove all styling of Global History content from theme.css

[Thomas.J.Waldmann, 2015-05-05 19:27:49]

https://codereview.appspot.com/235720043/diff/1/MoinMoin/themes/modernized/st...
File MoinMoin/themes/modernized/static/css/stylus/theme.styl (left):

https://codereview.appspot.com/235720043/diff/1/MoinMoin/themes/modernized/st...
MoinMoin/themes/modernized/static/css/stylus/theme.styl:255: #moin-page-history
wasn't moin page history and global history using almost the same code/template?
so it's now handled differently?

[RogerHaase, 2015-05-06 20:07:48]

https://codereview.appspot.com/235720043/diff/1/MoinMoin/themes/modernized/st...
File MoinMoin/themes/modernized/static/css/stylus/theme.styl (left):

https://codereview.appspot.com/235720043/diff/1/MoinMoin/themes/modernized/st...
MoinMoin/themes/modernized/static/css/stylus/theme.styl:255: #moin-page-history
On 2015/05/05 19:27:49, Thomas.J.Waldmann wrote:
> wasn't moin page history and global history using almost the same
code/template?
> so it's now handled differently?

Right, basic and modernized were using the same global history template and
still are. 

However, the CSS was largely different, with modernized having a better look
imho. Main problem with basic theme is it needed more CSS to override some of
the bootstrap defaults (e.g. there was an H2 tag under 3 levels of DIVs that was
displayed in a too large font).

So main work of "merge" part of this changeset was to rip out all related CSS
from the theme.css's and move it to common.css (same as all other merging of
templates to date).

But then I was a victim of scope creep, and noticed a couple of the tool tips
were wrong, the items within a date were not sorted, the Editor and Comment
fields were removed several changes back (to save horizontal space? who and why
seem important), and time changed was not needed down to the second.

[Thomas.J.Waldmann, 2015-05-09 15:35:38]

> > wasn't moin page history and global history using almost the same
> code/template?
> > so it's now handled differently?

my question was about page (local) vs. global history, did you notice that?

> Right, basic and modernized were using the same global history template and
> still are. 
> ...