Issue 235490043: Fix key error: num_units not defined in services.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 235490043: Fix key error: num_units not defined in services.

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 11 months ago by frankban

Modified:
8 years, 11 months ago

Reviewers:
urulama, mp+258972, martin.hilton

Visibility:
Public.

Description

Fix key error: num_units not defined in services. https://code.launchpad.net/~frankban/juju-quickstart/fix-num-units/+merge/258972 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix key error: num_units not defined in services. #

Patch Set 3 : Fix key error: num_units not defined in services. #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -4 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	quickstart/__init__.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	quickstart/models/bundles.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	quickstart/tests/functional/test_functional.py	View	1 chunk	+11 lines, -2 lines	0 comments	Download
M	quickstart/tests/models/test_bundles.py	View	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

martin.hilton

LGTM, but make sure that the default 0 is correct for all cases. https://codereview.appspot.com/235490043/diff/1/quickstart/models/bundles.py File ...

8 years, 11 months ago (2015-05-13 08:41:26 UTC) #2

urulama

On 2015/05/13 08:49:04, frankban wrote: > Please take a look. LGTM now.

8 years, 11 months ago (2015-05-13 08:52:09 UTC) #4

frankban

*** Submitted: Fix key error: num_units not defined in services. R=martin.hilton, uros.jovanovic1 CC= https://codereview.appspot.com/235490043

8 years, 11 months ago (2015-05-13 09:25:32 UTC) #5

Thanks for the reviews!

Expand All Messages | Collapse All Messages