Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4246)

Issue 234150043: Update provider fields.

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 12 months ago by frankban
Modified:
8 years, 12 months ago
Reviewers:
mp+257913
Visibility:
Public.

Description

Update provider fields. Update the list of fields that quickstart expects for each provider type. Also make some OpenStack fields optional (use-floating-ip, tenant-name and region). Update the links to the provider documentation (use jujucharms.com). Update the jujubundlelib dependency to use the latest one. Tests: `make check`. QA: - check that the environment editing in the interactive session looks good (especially the openstack/azure environments creation). - use quickstart as usual (`devenv/bin/juju-quickstart`), to start (for instance) an ec2 or an azure environment. https://code.launchpad.net/~frankban/juju-quickstart/optional-fields/+merge/257913 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Update provider fields. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -35 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M quickstart/cli/forms.py View 1 chunk +2 lines, -1 line 0 comments Download
M quickstart/models/envs.py View 14 chunks +56 lines, -19 lines 0 comments Download
M quickstart/tests/models/test_envs.py View 4 chunks +11 lines, -11 lines 0 comments Download
M tox.ini View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2
frankban
Please take a look.
8 years, 12 months ago (2015-04-30 15:41:50 UTC) #1
frankban
8 years, 12 months ago (2015-05-01 07:24:57 UTC) #2
*** Submitted:

Update provider fields.

Update the list of fields that quickstart
expects for each provider type. Also make
some OpenStack fields optional 
(use-floating-ip, tenant-name and region).

Update the links to the provider documentation
(use jujucharms.com).

Update the jujubundlelib dependency to use the
latest one.

Tests: `make check`.

QA:
- check that the environment editing in the
interactive session looks good 
(especially the openstack/azure environments
creation).
- use quickstart as usual 
(`devenv/bin/juju-quickstart`), to start 
(for instance) an ec2 or an azure environment.

R=
CC=
https://codereview.appspot.com/234150043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b