code review 23310043: runtime, gc: call interface conversion routines by refe...

runtime, gc: call interface conversion routines by reference.

Part of getting rid of vararg C calls.

[khr, 2013-12-02 21:19:19]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://khr%40golang.org@code.google.com/p/go/

[khr, 2013-12-18 00:32:47]

On 2013/12/02 21:19:19, khr wrote:
> Hello mailto:golang-dev@googlegroups.com,
> 
> I'd like you to review this change to
> https://khr%2540golang.org%40code.google.com/p/go/

Ping.

[bradfitz, 2013-12-18 00:49:57]

LGTM



On Tue, Dec 17, 2013 at 4:32 PM, <khr@golang.org> wrote:

> On 2013/12/02 21:19:19, khr wrote:
>
>> Hello mailto:golang-dev@googlegroups.com,
>>
>
>  I'd like you to review this change to
>> https://khr%2540golang.org%40code.google.com/p/go/
>>
>
> Ping.
>
>
> https://codereview.appspot.com/23310043/
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[khr, 2013-12-18 00:55:08]

*** Submitted as https://code.google.com/p/go/source/detail?r=e4cdf4d18e1e ***

runtime, gc: call interface conversion routines by reference.

Part of getting rid of vararg C calls.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/23310043

[rsc, 2013-12-18 02:53:55]

LGTM

I am sorry this sat for so long. I hope the new dashboard will help us avoid
dropping things on the floor quite so often.

[dvyukov, 2013-12-20 09:02:17]

FYI, this degraded json:

http://goperfd.appspot.com/perfdetail?commit=e4cdf4d18e1e96899898747b8823a512...

[dvyukov, 2013-12-22 15:27:14]

On 2013/12/20 09:02:17, dvyukov wrote:
> FYI, this degraded json:
> 
>
http://goperfd.appspot.com/perfdetail?commit=e4cdf4d18e1e96899898747b8823a512...

Windows builder confirms degradation:

Change e4cdf4d18e1e caused perf changes on windows-amd64:

json-1                    old          new      delta
cputime             192187500    201562500      +4.88

json-8                    old          new      delta
cputime             212062500    226281250      +6.70

http://goperfd.appspot.com/perfdetail?commit=e4cdf4d18e1e96899898747b8823a512...