Lift out setting up AsanRuntime from syzyasan_rtl.cc.

Lift out setting up AsanRuntime from syzyasan_rtl.cc.

BUG=
R=chrisha@chromium.org

Committed: https://code.google.com/p/syzygy/source/detail?r=f1989ab93184883e07b874d8bf075931fc545e2d

[cseri, 2015-04-25 00:47:23]

These functions were local anonymous functions in syzyasan_rtl module, but they
are also needed by the hot patching Asan runtime, so I moved them to a location
that is accessible from the syzyasan_hp_lib module.

This is one possible solution, if the freestanding functions are not nice
enough, they can be incorporated in a class. Or the whole stuff can be added to
the AsanRuntime class, but that is already huge.

PTAL.

[chrisha, 2015-04-27 15:18:20]

Maybe place these in asan_runtime_util.h and .cc? The general approach of
lifting these out is fine by me.

[cseri, 2015-04-28 17:43:38]

I've renamed the files to the suggested names. PTAL.

[chrisha, 2015-04-29 13:54:41]

https://codereview.appspot.com/232030043/diff/20001/syzygy/agent/asan/asan_ru...
File syzygy/agent/asan/asan_runtime_util.cc (right):

https://codereview.appspot.com/232030043/diff/20001/syzygy/agent/asan/asan_ru...
syzygy/agent/asan/asan_runtime_util.cc:184: void SetUpAsanRuntime(AsanRuntime**
asan_runtime) {
Need to check asan_runtime != null too.
Also, please move this to using the DCHECK_NE(static_cast<...> style.

https://codereview.appspot.com/232030043/diff/20001/syzygy/agent/asan/asan_ru...
syzygy/agent/asan/asan_runtime_util.cc:216: DCHECK(*asan_runtime != nullptr);
You need a DCHECK that asan_runtime itself isn't null either (need to check both
levels of the pointer).

https://codereview.appspot.com/232030043/diff/20001/syzygy/agent/asan/asan_ru...
File syzygy/agent/asan/asan_runtime_util.h (right):

https://codereview.appspot.com/232030043/diff/20001/syzygy/agent/asan/asan_ru...
syzygy/agent/asan/asan_runtime_util.h:14: 
This header file needs a comment describing what's in it.

https://codereview.appspot.com/232030043/diff/20001/syzygy/agent/asan/asan_ru...
syzygy/agent/asan/asan_runtime_util.h:23: void SetUpAsanRuntime(AsanRuntime**
asan_runtime);
Doxygen style comments for these functions please.

https://codereview.appspot.com/232030043/diff/20001/syzygy/agent/asan/syzyasa...
File syzygy/agent/asan/syzyasan_rtl.cc (right):

https://codereview.appspot.com/232030043/diff/20001/syzygy/agent/asan/syzyasa...
syzygy/agent/asan/syzyasan_rtl.cc:30: base::AtExitManager* at_exit = NULL;
While you're in this file please replace NULL with nullptr, and update the
DCHECKs with the static_cast style.

[cseri, 2015-04-29 15:31:23]

Updated everything. Are the new comments for the functions good?
PTAL.

https://codereview.appspot.com/232030043/diff/20001/syzygy/agent/asan/asan_ru...
File syzygy/agent/asan/asan_runtime_util.cc (right):

https://codereview.appspot.com/232030043/diff/20001/syzygy/agent/asan/asan_ru...
syzygy/agent/asan/asan_runtime_util.cc:184: void SetUpAsanRuntime(AsanRuntime**
asan_runtime) {
On 2015/04/29 13:54:41, chrisha wrote:
> Need to check asan_runtime != null too.
> Also, please move this to using the DCHECK_NE(static_cast<...> style.

Done.

https://codereview.appspot.com/232030043/diff/20001/syzygy/agent/asan/asan_ru...
syzygy/agent/asan/asan_runtime_util.cc:216: DCHECK(*asan_runtime != nullptr);
On 2015/04/29 13:54:41, chrisha wrote:
> You need a DCHECK that asan_runtime itself isn't null either (need to check
both
> levels of the pointer).

Done.

https://codereview.appspot.com/232030043/diff/20001/syzygy/agent/asan/asan_ru...
File syzygy/agent/asan/asan_runtime_util.h (right):

https://codereview.appspot.com/232030043/diff/20001/syzygy/agent/asan/asan_ru...
syzygy/agent/asan/asan_runtime_util.h:14: 
On 2015/04/29 13:54:41, chrisha wrote:
> This header file needs a comment describing what's in it.

Done.

https://codereview.appspot.com/232030043/diff/20001/syzygy/agent/asan/asan_ru...
syzygy/agent/asan/asan_runtime_util.h:23: void SetUpAsanRuntime(AsanRuntime**
asan_runtime);
On 2015/04/29 13:54:41, chrisha wrote:
> Doxygen style comments for these functions please.

Done.

https://codereview.appspot.com/232030043/diff/20001/syzygy/agent/asan/syzyasa...
File syzygy/agent/asan/syzyasan_rtl.cc (right):

https://codereview.appspot.com/232030043/diff/20001/syzygy/agent/asan/syzyasa...
syzygy/agent/asan/syzyasan_rtl.cc:30: base::AtExitManager* at_exit = NULL;
On 2015/04/29 13:54:41, chrisha wrote:
> While you're in this file please replace NULL with nullptr, and update the
> DCHECKs with the static_cast style.

Done.

[chrisha, 2015-04-29 17:09:29]

Awesome, lgtm!

[cseri, 2015-04-29 17:32:09]

On 2015/04/29 17:09:29, chrisha wrote:
> Awesome, lgtm!

Thanks, committing!

[cseri, 2015-04-29 17:51:27]

Committed patchset #3 (id:40001) manually as
f1989ab93184883e07b874d8bf075931fc545e2d (presubmit successful).