Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1499)

Issue 230860044: Updated patch for issue 155

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 5 months ago by Carl
Modified:
4 years, 5 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Updated patch for issue 155 This patch is updated from Joe Neeman's patch for issue 155 so it applies to current master. The main difference is the change in handling pure functions. I'm not an expert on this so I'm not sure I have it 100% right. But at least this works on the regtests. Please review.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated patch. Fixes typo, adds regtest. #

Total comments: 8

Patch Set 3 : Respond to Keith's comments. Eliminate pure-Y-extent. Clean up regression test. #

Patch Set 4 : Respond to Keith's comments. Eliminate pure-Y-extent. Clean up regression test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -2 lines) Patch
A input/regression/parenthesize-notes-accidentals.ly View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M lily/grob.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M scm/define-grob-properties.scm View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M scm/define-grobs.scm View 1 2 4 chunks +4 lines, -0 lines 0 comments Download
M scm/output-lib.scm View 1 2 1 chunk +15 lines, -2 lines 0 comments Download

Messages

Total messages: 9
Valentin Villenave
Hi Carl, thanks for resurrecting this patch! From what I understand, the logic behind this ...
4 years, 5 months ago (2015-04-15 06:26:02 UTC) #1
Carl
Updated patch. Fixes typo, adds regtest.
4 years, 5 months ago (2015-04-16 02:20:34 UTC) #2
Carl
On 2015/04/15 06:26:02, Valentin Villenave wrote: > Perhaps you could add a regtest demonstrating this ...
4 years, 5 months ago (2015-04-16 02:23:14 UTC) #3
Keith
LGTM. > The main difference is the change in handling pure functions. I can't see ...
4 years, 5 months ago (2015-04-19 19:32:29 UTC) #4
Carl
On 2015/04/19 19:32:29, Keith wrote: > LGTM. > > > The main difference is the ...
4 years, 5 months ago (2015-04-21 18:46:14 UTC) #5
Carl
https://codereview.appspot.com/230860044/diff/20001/scm/define-grob-properties.scm File scm/define-grob-properties.scm (right): https://codereview.appspot.com/230860044/diff/20001/scm/define-grob-properties.scm#newcode777 scm/define-grob-properties.scm:777: (parenthesis-friends ,list? "A lisy of symbols. Any parenthesis On ...
4 years, 5 months ago (2015-04-21 18:46:38 UTC) #6
Keith
https://codereview.appspot.com/230860044/diff/20001/input/regression/parenthesize-notes-accidentals.ly File input/regression/parenthesize-notes-accidentals.ly (right): https://codereview.appspot.com/230860044/diff/20001/input/regression/parenthesize-notes-accidentals.ly#newcode10 input/regression/parenthesize-notes-accidentals.ly:10: <\parenthesize ais'>4. <\parenthesize bes'> These parentheses overlap, which seems ...
4 years, 5 months ago (2015-04-22 04:04:33 UTC) #7
Carl
Respond to Keith's comments. Eliminate pure-Y-extent. Clean up regression test.
4 years, 5 months ago (2015-04-22 21:50:54 UTC) #8
Carl
4 years, 5 months ago (2015-04-22 21:51:31 UTC) #9
Respond to Keith's comments.  Eliminate pure-Y-extent.  Clean up regression test
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b