Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(757)

Issue 229760043: Improved JSON serialization with typing. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 11 months ago by Joachim Metz
Modified:
8 years, 10 months ago
Reviewers:
kiddi, onager
CC:
log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

These files are missing unit tests: + plaso/dependencies.py

Patch Set 1 #

Patch Set 2 : Uploading changes made to code. #

Total comments: 7

Patch Set 3 : Uploading changes made to code. #

Patch Set 4 : Submitted. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+377 lines, -115 lines) Patch
M config/dpkg/changelog View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M plaso/dependencies.py View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M plaso/output/json_out.py View 1 2 1 chunk +10 lines, -9 lines 0 comments Download
M plaso/output/json_out_test.py View 1 2 4 chunks +39 lines, -19 lines 0 comments Download
M plaso/serializer/json_serializer.py View 1 2 3 chunks +259 lines, -39 lines 0 comments Download
M plaso/serializer/json_serializer_test.py View 1 2 8 chunks +65 lines, -44 lines 0 comments Download

Messages

Total messages: 15
Joachim Metz
8 years, 11 months ago (2015-04-08 20:23:27 UTC) #1
Joachim Metz
Code updated.
8 years, 11 months ago (2015-04-08 20:29:14 UTC) #2
Joachim Metz
https://codereview.appspot.com/229760043/diff/20001/plaso/dependencies.py File plaso/dependencies.py (right): https://codereview.appspot.com/229760043/diff/20001/plaso/dependencies.py#newcode37 plaso/dependencies.py:37: (u'dfvfs', u'__version__', u'20150408', None), note to self before push ...
8 years, 11 months ago (2015-04-09 08:58:37 UTC) #3
kiddi
Does this negatively affect JSON decode/encode speed? As in have you measured the impact this ...
8 years, 11 months ago (2015-04-13 17:30:44 UTC) #4
Joachim Metz
On 2015/04/13 17:30:44, kiddi wrote: > Does this negatively affect JSON decode/encode speed? As in ...
8 years, 11 months ago (2015-04-13 17:46:11 UTC) #5
onager
https://codereview.appspot.com/229760043/diff/20001/plaso/dependencies.py File plaso/dependencies.py (right): https://codereview.appspot.com/229760043/diff/20001/plaso/dependencies.py#newcode154 plaso/dependencies.py:154: libyal_python_modules: a dictionary of libyal python module name as ...
8 years, 11 months ago (2015-04-21 21:25:43 UTC) #6
Joachim Metz
https://codereview.appspot.com/229760043/diff/20001/plaso/dependencies.py File plaso/dependencies.py (right): https://codereview.appspot.com/229760043/diff/20001/plaso/dependencies.py#newcode154 plaso/dependencies.py:154: libyal_python_modules: a dictionary of libyal python module name as ...
8 years, 11 months ago (2015-04-22 05:27:29 UTC) #7
Joachim Metz
Code updated.
8 years, 11 months ago (2015-04-22 06:00:51 UTC) #8
Joachim Metz
On 2015/04/22 06:00:51, Joachim Metz wrote: > Code updated. Tested with the serializers profiler and ...
8 years, 11 months ago (2015-04-24 04:06:27 UTC) #9
Joachim Metz
On 2015/04/24 04:06:27, Joachim Metz wrote: > On 2015/04/22 06:00:51, Joachim Metz wrote: > > ...
8 years, 11 months ago (2015-04-24 05:10:46 UTC) #10
kiddi
Running this CL through the current codebase and against the nfury test image I get ...
8 years, 11 months ago (2015-04-26 02:56:01 UTC) #11
kiddi
but otherwise I couldn't see any issues with this CL and the odd thing is ...
8 years, 11 months ago (2015-04-26 03:11:54 UTC) #12
onager
On 2015/04/26 03:11:54, kiddi wrote: > but otherwise I couldn't see any issues with this ...
8 years, 10 months ago (2015-05-07 13:53:16 UTC) #13
kiddi
Unable to reproduce error at this point, so LGTM and we'll create a bug if ...
8 years, 10 months ago (2015-05-07 14:05:11 UTC) #14
Joachim Metz
8 years, 10 months ago (2015-05-07 21:25:16 UTC) #15
Code Submitted.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b