Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1435)

Issue 22940044: code review 22940044: misc/vim: use goimports for :Fmt if it exists (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by crawshaw1
Modified:
6 years, 2 months ago
CC:
dsymonds, Dominik Honnef, niemeyer, rsc, kisielk, golang-dev
Visibility:
Public.

Description

misc/vim: add a gofmt_command flag for :Fmt

Patch Set 1 #

Patch Set 2 : diff -r 6ad0ec54cf2d https://code.google.com/p/go #

Patch Set 3 : diff -r 6ad0ec54cf2d https://code.google.com/p/go #

Patch Set 4 : diff -r 6ad0ec54cf2d https://code.google.com/p/go #

Patch Set 5 : diff -r 6ad0ec54cf2d https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M misc/vim/ftplugin/go/fmt.vim View 1 2 3 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 13
crawshaw1
Hello dsymonds@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
6 years, 2 months ago (2013-11-11 17:26:23 UTC) #1
Dominik Honnef
I'm not sure that the mere presence of the tool should be considered a preference ...
6 years, 2 months ago (2013-11-11 18:28:44 UTC) #2
niemeyer
On 2013/11/11 18:28:44, Dominik Honnef wrote: > I'm not sure that the mere presence of ...
6 years, 2 months ago (2013-11-11 18:35:29 UTC) #3
rsc
same
6 years, 2 months ago (2013-11-11 18:36:23 UTC) #4
kisielk
More common in vim plugins is something like: if !exists("g:gofmt_command") let g:gofmt_command = "gofmt" endif ...
6 years, 2 months ago (2013-11-11 18:47:41 UTC) #5
crawshaw1
PTAL
6 years, 2 months ago (2013-11-11 19:33:03 UTC) #6
Dominik Honnef
LGTM, but update the CL description
6 years, 2 months ago (2013-11-11 19:38:36 UTC) #7
kisielk
LGTM, the variable naming is a bit unfortunate though. Not sure how best to improve ...
6 years, 2 months ago (2013-11-11 19:40:34 UTC) #8
Dominik Honnef
On 2013/11/11 19:40:34, kisielk wrote: > LGTM, the variable naming is a bit unfortunate though. ...
6 years, 2 months ago (2013-11-11 19:42:22 UTC) #9
kisielk
What I meant was that having go_fmt_commands and gofmt_command as variable names seems a bit ...
6 years, 2 months ago (2013-11-11 19:47:50 UTC) #10
niemeyer
LGTM
6 years, 2 months ago (2013-11-11 19:59:18 UTC) #11
dsymonds
LGTM
6 years, 2 months ago (2013-11-11 22:27:41 UTC) #12
dsymonds
6 years, 2 months ago (2013-11-11 22:28:15 UTC) #13
*** Submitted as https://code.google.com/p/go/source/detail?r=39c724dd7f25 ***

misc/vim: add a gofmt_command flag for :Fmt

R=dsymonds, dominik.honnef, n13m3y3r, rsc, kamil.kisiel
CC=golang-dev
https://codereview.appspot.com/22940044

Committer: David Symonds <dsymonds@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b