On 2013/11/11 18:28:44, Dominik Honnef wrote: > I'm not sure that the mere presence of ...
10 years, 4 months ago
(2013-11-11 18:35:29 UTC)
#3
On 2013/11/11 18:28:44, Dominik Honnef wrote:
> I'm not sure that the mere presence of the tool should be considered a
> preference for it.
Agreed.
It'd be better to have an option, such as FormatCommand, that may be set to
whatever the user wants.
More common in vim plugins is something like: if !exists("g:gofmt_command") let g:gofmt_command = "gofmt" endif ...
10 years, 4 months ago
(2013-11-11 18:47:41 UTC)
#5
More common in vim plugins is something like:
if !exists("g:gofmt_command")
let g:gofmt_command = "gofmt"
endif
Then in their .vimrc users could do:
let g:gofmt_command ="goimports"
On 2013/11/11 19:40:34, kisielk wrote: > LGTM, the variable naming is a bit unfortunate though. ...
10 years, 4 months ago
(2013-11-11 19:42:22 UTC)
#9
On 2013/11/11 19:40:34, kisielk wrote:
> LGTM, the variable naming is a bit unfortunate though. Not sure how best to
> improve it.
I think the name is fine, really. goimports is, technically, "a gofmt". That's
why it's a drop-in replacement.
For what it is worth, we went with the same variable name in go-mode for Emacs.
*** Submitted as https://code.google.com/p/go/source/detail?r=39c724dd7f25 *** misc/vim: add a gofmt_command flag for :Fmt R=dsymonds, dominik.honnef, n13m3y3r, ...
10 years, 4 months ago
(2013-11-11 22:28:15 UTC)
#13
Issue 22940044: code review 22940044: misc/vim: use goimports for :Fmt if it exists
(Closed)
Created 10 years, 4 months ago by crawshaw1
Modified 10 years, 4 months ago
Reviewers:
Base URL:
Comments: 0