Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(25)

Issue 2289041: code review 2289041: gc, spec, tests: no auto-indirect of pointer to interfa... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 2 months ago by rsc
Modified:
5 days, 21 hours ago
Reviewers:
r, gri
CC:
gri, iant, ken2, r, r2, golang-dev
Visibility:
Public.

Description

gc, spec, tests: no auto-indirect of pointer to interface value Implies no embedding of pointer to interface value either.

Patch Set 1 #

Patch Set 2 : code review 2289041: gc, spec, tests: no auto-indirect of pointer to interfa... #

Total comments: 3

Patch Set 3 : code review 2289041: gc, spec, tests: no auto-indirect of pointer to interfa... #

Total comments: 1

Patch Set 4 : code review 2289041: gc, spec, tests: no auto-indirect of pointer to interfa... #

Patch Set 5 : code review 2289041: gc, spec, tests: no auto-indirect of pointer to interfa... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -76 lines) Patch
M doc/go_spec.html View 1 2 3 4 3 chunks +10 lines, -13 lines 0 comments Download
M src/cmd/gc/dcl.c View 1 chunk +4 lines, -1 line 0 comments Download
M src/cmd/gc/reflect.c View 1 chunk +0 lines, -9 lines 0 comments Download
M src/cmd/gc/typecheck.c View 1 chunk +1 line, -1 line 0 comments Download
M test/hashmap.go View 5 chunks +6 lines, -6 lines 0 comments Download
M test/interface/embed.go View 3 chunks +1 line, -22 lines 0 comments Download
M test/interface/embed2.go View 3 chunks +7 lines, -19 lines 0 comments Download
M test/method.go View 1 chunk +0 lines, -5 lines 0 comments Download
M test/method2.go View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11
rsc
Hello gri, iant, ken2, r (cc: golang-dev@googlegroups.com), I'd like you to review this change.
8 years, 2 months ago (2010-09-28 19:29:45 UTC) #1
r
LGTM
8 years, 2 months ago (2010-09-28 20:28:31 UTC) #2
gri
http://codereview.appspot.com/2289041/diff/1010/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/2289041/diff/1010/doc/go_spec.html#newcode884 doc/go_spec.html:884: (also called an embedded field). We called them "embedded ...
8 years, 2 months ago (2010-09-28 20:29:06 UTC) #3
r2
On Sep 28, 2010, at 1:29 PM, gri@golang.org wrote: > > http://codereview.appspot.com/2289041/diff/1010/doc/go_spec.html > File doc/go_spec.html ...
8 years, 2 months ago (2010-09-28 21:38:32 UTC) #4
gri
Its fine with me, but I think it will make the use of "embedded" more ...
8 years, 2 months ago (2010-09-29 00:03:12 UTC) #5
rsc
PTAL Changed the selector part that Robert found and changed the text above it to ...
8 years, 2 months ago (2010-09-29 00:19:55 UTC) #6
r
LGTM http://codereview.appspot.com/2289041/diff/10001/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/2289041/diff/10001/doc/go_spec.html#newcode884 doc/go_spec.html:884: (also called an embedded field). s/also/colloquially/ ?
8 years, 2 months ago (2010-09-29 00:23:54 UTC) #7
rsc
> s/also/colloquially/ ? Done.
8 years, 2 months ago (2010-09-29 00:26:09 UTC) #8
rsc
I am not proposing to change the preferred name. The spec calls them anonymous everywhere, ...
8 years, 2 months ago (2010-09-29 00:58:44 UTC) #9
gri
LGTM On Tue, Sep 28, 2010 at 12:29 PM, <rsc@golang.org> wrote: > Reviewers: gri, iant, ...
8 years, 2 months ago (2010-09-29 03:49:42 UTC) #10
rsc
8 years, 2 months ago (2010-09-30 18:59:46 UTC) #11
*** Submitted as 54014073d377 ***

gc, spec, tests: no auto-indirect of pointer to interface value

Implies no embedding of pointer to interface value either.

R=gri, iant, ken2, r, r2
CC=golang-dev
http://codereview.appspot.com/2289041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b