Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(278)

Issue 228850043: Bugfix (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 11 months ago by Valentin Villenave
Modified:
5 years, 1 month ago
Reviewers:
Visibility:
Public.

Description

Bugfix After some debugging, this version of the patch doesn’t break major features (but it does alter the output of several regtests, namely trill-spanner-pitched-forced, graphviz, font-family-override and profile-property-access, which shouldn’t happen and requires to be investigated further). Bugfix

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+487 lines, -467 lines) Patch
lily/accidental-engraver.cc View 3 chunks +4 lines, -3 lines 0 comments Download
lily/accidental-placement.cc View 2 chunks +2 lines, -2 lines 0 comments Download
lily/align-interface.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/ambitus-engraver.cc View 1 chunk +2 lines, -2 lines 0 comments Download
lily/auto-beam-engraver.cc View 2 chunks +6 lines, -7 lines 0 comments Download
lily/axis-group-interface.cc View 2 chunks +8 lines, -8 lines 0 comments Download
lily/bar-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/bar-number-engraver.cc View 2 chunks +5 lines, -3 lines 0 comments Download
lily/beam.cc View 3 chunks +5 lines, -4 lines 0 comments Download
lily/beam-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/break-align-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/break-alignment-interface.cc View 4 chunks +6 lines, -6 lines 0 comments Download
lily/break-substitution.cc View 2 chunks +3 lines, -3 lines 0 comments Download
lily/chord-name-engraver.cc View 2 chunks +2 lines, -2 lines 0 comments Download
lily/clef-engraver.cc View 1 chunk +5 lines, -5 lines 0 comments Download
lily/constrained-breaking.cc View 1 chunk +3 lines, -3 lines 0 comments Download
lily/context.cc View 4 chunks +4 lines, -4 lines 0 comments Download
lily/context-def.cc View 5 chunks +19 lines, -19 lines 0 comments Download
lily/context-mod-scheme.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/context-property.cc View 1 chunk +5 lines, -5 lines 0 comments Download
lily/context-scheme.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/cue-clef-engraver.cc View 1 chunk +3 lines, -3 lines 0 comments Download
lily/directional-element-interface.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/dot-column.cc View 1 chunk +3 lines, -2 lines 0 comments Download
lily/double-percent-repeat-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/drum-note-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/duration-scheme.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/dynamic-engraver.cc View 4 chunks +7 lines, -6 lines 0 comments Download
lily/engraver.cc View 3 chunks +5 lines, -5 lines 0 comments Download
lily/engraver-group.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/font-interface.cc View 2 chunks +2 lines, -2 lines 0 comments Download
lily/general-scheme.cc View 7 chunks +9 lines, -9 lines 0 comments Download
lily/glissando-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/grob.cc View 1 chunk +4 lines, -4 lines 0 comments Download
lily/grob-interface.cc View 2 chunks +2 lines, -2 lines 0 comments Download
lily/grob-property.cc View 6 chunks +8 lines, -8 lines 0 comments Download
lily/grob-scheme.cc View 4 chunks +7 lines, -7 lines 0 comments Download
lily/include/lily-guile.hh View 1 chunk +2 lines, -1 line 0 comments Download
M lily/include/lily-guile-macros.hh View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/key-engraver.cc View 2 chunks +2 lines, -2 lines 0 comments Download
lily/lexer.ll View 14 chunks +18 lines, -18 lines 0 comments Download
lily/ligature-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/lily-guile.cc View 4 chunks +8 lines, -8 lines 0 comments Download
lily/lily-lexer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
lily/lily-parser.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/lily-parser-scheme.cc View 2 chunks +3 lines, -3 lines 0 comments Download
lily/line-interface.cc View 1 chunk +6 lines, -5 lines 0 comments Download
lily/line-spanner.cc View 3 chunks +3 lines, -3 lines 0 comments Download
lily/mark-engraver.cc View 1 chunk +2 lines, -2 lines 0 comments Download
lily/measure-grouping-spanner.cc View 1 chunk +2 lines, -2 lines 0 comments Download
lily/mensural-ligature.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/metronome-engraver.cc View 2 chunks +3 lines, -3 lines 0 comments Download
lily/midi-item.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/module-scheme.cc View 1 chunk +2 lines, -2 lines 0 comments Download
lily/multi-measure-rest.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/multi-measure-rest-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/music.cc View 1 chunk +5 lines, -5 lines 0 comments Download
lily/new-fingering-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/note-collision.cc View 1 chunk +4 lines, -2 lines 0 comments Download
lily/open-type-font.cc View 2 chunks +2 lines, -2 lines 0 comments Download
lily/output-def.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M lily/output-def-scheme.cc View 1 chunk +2 lines, -2 lines 0 comments Download
lily/page-breaking.cc View 5 chunks +7 lines, -5 lines 0 comments Download
lily/page-layout-problem.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/page-spacing.cc View 1 chunk +2 lines, -1 line 0 comments Download
lily/page-turn-engraver.cc View 3 chunks +6 lines, -5 lines 0 comments Download
lily/page-turn-page-breaking.cc View 1 chunk +2 lines, -1 line 0 comments Download
lily/pango-font.cc View 1 chunk +2 lines, -2 lines 0 comments Download
lily/pango-select.cc View 3 chunks +9 lines, -9 lines 0 comments Download
lily/paper-book.cc View 9 chunks +10 lines, -10 lines 0 comments Download
lily/paper-column.cc View 1 chunk +3 lines, -3 lines 0 comments Download
lily/paper-column-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
lily/paper-outputter.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/paper-score.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/paper-system.cc View 3 chunks +5 lines, -5 lines 0 comments Download
lily/parse-scm.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/parser.yy View 8 chunks +16 lines, -16 lines 0 comments Download
M lily/part-combine-engraver.cc View 1 chunk +3 lines, -3 lines 0 comments Download
lily/part-combine-iterator.cc View 1 chunk +11 lines, -11 lines 0 comments Download
lily/percent-repeat-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/piano-pedal-engraver.cc View 1 chunk +4 lines, -4 lines 0 comments Download
lily/pitched-trill-engraver.cc View 2 chunks +4 lines, -4 lines 0 comments Download
lily/prob.cc View 2 chunks +5 lines, -6 lines 0 comments Download
lily/prob-scheme.cc View 1 chunk +2 lines, -2 lines 0 comments Download
lily/profile.cc View 2 chunks +4 lines, -4 lines 0 comments Download
lily/program-option-scheme.cc View 2 chunks +2 lines, -2 lines 0 comments Download
lily/quote-iterator.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/repeat-acknowledge-engraver.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M lily/score.cc View 2 chunks +2 lines, -2 lines 0 comments Download
lily/score-performer.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/score-scheme.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/script-engraver.cc View 4 chunks +5 lines, -5 lines 0 comments Download
lily/script-interface.cc View 2 chunks +3 lines, -3 lines 0 comments Download
lily/self-alignment-interface.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/simple-closure.cc View 4 chunks +4 lines, -4 lines 0 comments Download
lily/simple-spacer.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/simple-spacer-scheme.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/skyline.cc View 2 chunks +2 lines, -2 lines 0 comments Download
lily/slur.cc View 8 chunks +12 lines, -10 lines 0 comments Download
M lily/slur-configuration.cc View 1 chunk +2 lines, -2 lines 0 comments Download
lily/slur-scoring.cc View 2 chunks +4 lines, -2 lines 0 comments Download
lily/smobs.cc View 2 chunks +3 lines, -3 lines 0 comments Download
lily/spaceable-grob.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/spacing-determine-loose-columns.cc View 1 chunk +2 lines, -1 line 0 comments Download
lily/staff-performer.cc View 5 chunks +7 lines, -7 lines 0 comments Download
lily/staff-spacing.cc View 1 chunk +5 lines, -5 lines 0 comments Download
lily/stem.cc View 1 chunk +2 lines, -1 line 0 comments Download
lily/stem-tremolo.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/stencil.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/stencil-expression.cc View 1 chunk +1 line, -2 lines 0 comments Download
lily/stencil-integral.cc View 16 chunks +31 lines, -31 lines 0 comments Download
M lily/stencil-interpret.cc View 7 chunks +13 lines, -13 lines 0 comments Download
lily/stencil-scheme.cc View 3 chunks +8 lines, -8 lines 0 comments Download
lily/stream-event.cc View 1 chunk +3 lines, -3 lines 0 comments Download
lily/stream-event-scheme.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/system.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/system-start-delimiter.cc View 1 chunk +4 lines, -4 lines 0 comments Download
lily/system-start-delimiter-engraver.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M lily/tab-note-heads-engraver.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M lily/tie-formatting-problem.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/tie-specification.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/time-signature-engraver.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/translator-ctors.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/translator-group-ctors.cc View 1 chunk +4 lines, -4 lines 0 comments Download
lily/ttf.cc View 2 chunks +2 lines, -2 lines 0 comments Download
lily/tuplet-bracket.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/vaticana-ligature.cc View 3 chunks +3 lines, -3 lines 0 comments Download
lily/vaticana-ligature-engraver.cc View 3 chunks +3 lines, -3 lines 0 comments Download
lily/volta-engraver.cc View 1 chunk +2 lines, -2 lines 0 comments Download
lily/volta-repeat-iterator.cc View 1 chunk +1 line, -1 line 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b