Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(802)

Issue 228700043: Issue 4356: Part combiner: generate mark events in scheme rather than C++ (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years ago by Dan Eble
Modified:
8 years, 11 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Eliminate new kind of context #

Patch Set 3 : Eliminate unnecessary nesting #

Total comments: 2

Patch Set 4 : add \with as David suggests #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -90 lines) Patch
M lily/part-combine-iterator.cc View 6 chunks +1 line, -48 lines 0 comments Download
M ly/music-functions-init.ly View 1 2 3 4 2 chunks +30 lines, -42 lines 0 comments Download
M scm/part-combiner.scm View 1 1 chunk +67 lines, -0 lines 0 comments Download

Messages

Total messages: 8
Dan Eble
9 years ago (2015-04-25 03:29:18 UTC) #1
Dan Eble
On 2015/04/25 03:29:18, Dan Eble wrote: Recent discussion with Keith on the devel list makes ...
8 years, 12 months ago (2015-04-27 01:21:19 UTC) #2
Dan Eble
Eliminate new kind of context
8 years, 12 months ago (2015-04-28 02:29:44 UTC) #3
Dan Eble
Eliminate unnecessary nesting
8 years, 12 months ago (2015-04-28 03:02:49 UTC) #4
dak
https://codereview.appspot.com/228700043/diff/40001/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/228700043/diff/40001/ly/music-functions-init.ly#newcode1135 ly/music-functions-init.ly:1135: \context Voice = "one" \with { #one-context-settings } {} ...
8 years, 11 months ago (2015-05-02 17:43:25 UTC) #5
Dan Eble
add \with as David suggests
8 years, 11 months ago (2015-05-02 18:22:14 UTC) #6
Dan Eble
rebase
8 years, 11 months ago (2015-05-04 01:34:29 UTC) #7
Dan Eble
8 years, 11 months ago (2015-05-04 01:34:51 UTC) #8
rebase
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b