Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6)

Issue 2275042: Fix #888: Add ly:stencil-scale. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by Neil Puttock
Modified:
4 years, 4 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix #888: Add ly:stencil-scale. * lily/stencil-interpret.cc (interpret_stencil_expression): interpret new stencil command `scale-stencil', unscaling offset of body to compensate for change in output scale * lily/stencil-scheme.cc (ly_stencil_scale): export new function `ly:stencil-scale' * lily/stencil.cc, include/stencil.hh (scale): new method for scaling stencils * scm/define-markup-commands.scm (scale): new markup command * scm/define-stencil-commands.scm (ly:all-stencil-commands): add stencil commands for setting and resetting scale (`setscale', `resetscale') (ly:all-output-backend-commands): add `scale-stencil' command * scm/output-ps.scm, output-svg.scm (setscale, resetscale): implement stencil outputters for scaling

Patch Set 1 #

Patch Set 2 : Add regtest and doc markup command. #

Total comments: 4

Patch Set 3 : Respond to comments. #

Patch Set 4 : Update version in regtest. #

Patch Set 5 : Remove newline. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -2 lines) Patch
A input/regression/stencil-scale.ly View 2 3 4 1 chunk +23 lines, -0 lines 0 comments Download
M lily/include/stencil.hh View 1 chunk +1 line, -0 lines 0 comments Download
M lily/stencil.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M lily/stencil-interpret.cc View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
M lily/stencil-scheme.cc View 1 1 chunk +17 lines, -0 lines 1 comment Download
M scm/define-markup-commands.scm View 1 2 1 chunk +30 lines, -0 lines 1 comment Download
M scm/define-stencil-commands.scm View 2 chunks +3 lines, -2 lines 0 comments Download
M scm/output-ps.scm View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M scm/output-svg.scm View 1 2 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12
Valentin Villenave
http://codereview.appspot.com/2275042/diff/2001/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): http://codereview.appspot.com/2275042/diff/2001/scm/define-markup-commands.scm#newcode3375 scm/define-markup-commands.scm:3375: (number? number? markup?) Hi Neil, your patch looks awesome! ...
4 years, 5 months ago (2010-10-04 10:36:47 UTC) #1
Patrick McCarty
Hi Neil, Looks great! I just have a couple of comments for you (below). Thanks, ...
4 years, 5 months ago (2010-10-08 05:32:32 UTC) #2
Neil Puttock
On 2010/10/04 10:36:47, Valentin Villenave wrote: > Hi Neil, your patch looks awesome! Thanks. > ...
4 years, 5 months ago (2010-10-24 11:46:39 UTC) #3
Neil Puttock
On 2010/10/08 05:32:32, Patrick McCarty wrote: > Looks great! Thanks. > http://codereview.appspot.com/2275042/diff/2001/input/regression/stencil-scale.ly > File input/regression/stencil-scale.ly ...
4 years, 5 months ago (2010-10-24 11:51:22 UTC) #4
Patrick McCarty
LGTM. Thanks, Patrick
4 years, 5 months ago (2010-10-25 05:41:21 UTC) #5
lemzwerg
LGTM too. http://codereview.appspot.com/2275042/diff/18001/lily/stencil-scheme.cc File lily/stencil-scheme.cc (right): http://codereview.appspot.com/2275042/diff/18001/lily/stencil-scheme.cc#newcode398 lily/stencil-scheme.cc:398: { Don't say @code{@var{...}} but @var{...}. http://codereview.appspot.com/2275042/diff/18001/scm/define-markup-commands.scm ...
4 years, 5 months ago (2010-10-25 06:03:36 UTC) #6
Neil Puttock
On 2010/10/25 06:03:36, lemzwerg wrote: > Don't say @code{@var{...}} but @var{...}. Hmm, have I misinterpreted ...
4 years, 5 months ago (2010-10-25 21:53:54 UTC) #7
wl_gnu.org
>> Don't say @code{@var{...}} but @var{...}. > > Hmm, have I misinterpreted Mark's post here?: ...
4 years, 5 months ago (2010-10-26 05:52:08 UTC) #8
Mark Polesky
On 2010/10/26 05:52:08, wl_gnu.org wrote: > Well, have a look at section A.17 (Scheme functions) ...
4 years, 5 months ago (2010-10-26 08:21:41 UTC) #9
wl_gnu.org
> I'm the one that wrote the @var description there. And yes, the > rationale ...
4 years, 5 months ago (2010-10-26 12:07:47 UTC) #10
Carl
On 2010/10/26 08:21:41, Mark Polesky wrote: > Well... Okay, yeah, but see this: > http://kainhofer.com/%7Elilypond/Documentation/contributor/syntax-survey.html#miscellany ...
4 years, 5 months ago (2010-10-27 18:39:30 UTC) #11
Graham Percival
4 years, 5 months ago (2010-10-29 06:09:10 UTC) #12
On Wed, Oct 27, 2010 at 06:39:30PM +0000, Carl.D.Sorensen@gmail.com wrote:
> I think that wrapping a variable declaration in a code declaration is
> undesirable.  It complicates the format of the documentation, for very
> little benefit (if any).
> 
> If we want to change the format of @var{} in HTML and PDF format, we
> ought to be able to do that in our texinfo program.

I like this idea.  We're never going to want a non-code variable
in our docs.

Cheers,
- Graham
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e6eadc5