Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(194)

Issue 227470043: Doc Issue 4350: \compressFullBarRests needs a warning (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 11 months ago by Trevor Daniels
Modified:
8 years, 10 months ago
Reviewers:
Jean-Charles
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc Issue 4350: \compressFullBarRests needs a warning The \compressFullBarRests predef, which simply sets skipBars true, can generate incorrectly set music if used carelessly. The problem is that its action is not restricted to rests: it removes bar lines whenever a rest or a _note_ crosses a bar line. Add a warning to the NR and point to it from the LM. Use \compressFullBarRests in the LM example rather than explicitly setting skipBars, and show how the rests should be bracketed between \compressFullBarRests and \expandFullBarRests.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -6 lines) Patch
M Documentation/learning/fundamental.itely View 1 chunk +17 lines, -6 lines 2 comments Download
M Documentation/notation/rhythms.itely View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Jean-Charles
Otherwise, LGTM https://codereview.appspot.com/227470043/diff/1/Documentation/learning/fundamental.itely File Documentation/learning/fundamental.itely (right): https://codereview.appspot.com/227470043/diff/1/Documentation/learning/fundamental.itely#newcode3193 Documentation/learning/fundamental.itely:3193: r4 f8 a | cis4 f | ...
8 years, 11 months ago (2015-04-24 17:16:28 UTC) #1
Trevor Daniels
https://codereview.appspot.com/227470043/diff/1/Documentation/learning/fundamental.itely File Documentation/learning/fundamental.itely (right): https://codereview.appspot.com/227470043/diff/1/Documentation/learning/fundamental.itely#newcode3193 Documentation/learning/fundamental.itely:3193: r4 f8 a | cis4 f | e4 d ...
8 years, 11 months ago (2015-04-26 20:23:03 UTC) #2
Trevor Daniels
8 years, 10 months ago (2015-05-29 15:52:38 UTC) #3
Message was sent while issue was closed.
This patch is no longer required.  See Issue 3687.
Closing ...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b