Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(23)

Issue 225380043: C++/SCM typing strictness, round 2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 11 months ago by Valentin Villenave
Modified:
5 years, 1 month ago
Reviewers:
pkx166h, dak, Dan Eble
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

C++/SCM typing strictness, round 2 Here’s a look at some of the remaining errors preventing LilyPond from being build with SCM_DEBUG_TYPING_STRICTNESS=2 For now, I had to just place a few TODO comments because I haven’t got the hang of it (yet).

Patch Set 1 #

Patch Set 2 : Rebase & update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -37 lines) Patch
M lily/accidental-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/axis-group-interface.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/book-scheme.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/break-alignment-interface.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M lily/clef-engraver.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M lily/context.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M lily/cue-clef-engraver.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M lily/drum-note-engraver.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M lily/extender-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/function-documentation.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M lily/grob-interface-scheme.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M lily/grob-pq-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/key-engraver.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M lily/ly-module.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M lily/module-scheme.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M lily/music.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/ottava-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/output-def-scheme.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/page-breaking.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/page-layout-problem.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/paper-book.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/paper-column.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M lily/parser.yy View 1 chunk +2 lines, -2 lines 0 comments Download
M lily/prob-scheme.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M lily/profile.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M lily/program-option-scheme.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M lily/protected-scm.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/scheme-engraver.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M lily/scm-hash.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M lily/script-column.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M lily/simple-spacer.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/spring-smob.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M lily/stanza-number-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/stencil-expression.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M lily/time-signature-engraver.cc View 1 chunk +1 line, -2 lines 0 comments Download
M lily/translator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
Valentin Villenave
Rebase & update
8 years, 11 months ago (2015-04-22 10:27:34 UTC) #1
Valentin Villenave
Greetings everybody, Quite a few TODO remain wherever I’m not sure exactly what to do; ...
8 years, 11 months ago (2015-04-22 10:33:28 UTC) #2
Valentin Villenave
8 years, 11 months ago (2015-04-22 19:50:22 UTC) #3
Rebase & update
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b