Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(105)

Issue 224720043: Unflatten JSON output (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years ago by f-s-p
Modified:
8 years, 10 months ago
Reviewers:
Joachim Metz
CC:
log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

.

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -6 lines) Patch
M plaso/output/json_out.py View 2 chunks +22 lines, -2 lines 4 comments Download
M plaso/output/json_out_test.py View 1 chunk +4 lines, -4 lines 1 comment Download

Messages

Total messages: 16
f-s-p
9 years ago (2015-03-27 00:36:06 UTC) #1
Joachim Metz
https://codereview.appspot.com/224720043/diff/1/plaso/output/json_out.py File plaso/output/json_out.py (right): https://codereview.appspot.com/224720043/diff/1/plaso/output/json_out.py#newcode56 plaso/output/json_out.py:56: if 'pathspec' in json_dict and isinstance(json_dict['pathspec'], I opt to ...
9 years ago (2015-03-27 07:12:21 UTC) #2
Joachim Metz
https://codereview.appspot.com/224720043/diff/1/plaso/output/json_out_test.py File plaso/output/json_out_test.py (right): https://codereview.appspot.com/224720043/diff/1/plaso/output/json_out_test.py#newcode90 plaso/output/json_out_test.py:90: expected_event_body = ( Please make sure this file is ...
9 years ago (2015-03-27 19:47:49 UTC) #3
f-s-p
https://codereview.appspot.com/224720043/diff/1/plaso/output/json_out.py File plaso/output/json_out.py (right): https://codereview.appspot.com/224720043/diff/1/plaso/output/json_out.py#newcode56 plaso/output/json_out.py:56: if 'pathspec' in json_dict and isinstance(json_dict['pathspec'], On 2015/03/27 07:12:18, ...
9 years ago (2015-03-31 21:15:27 UTC) #4
Joachim Metz
ReadSerialized would need to be changed as well. I was thinking along the lines of ...
9 years ago (2015-03-31 21:35:15 UTC) #5
Joachim Metz
know that: https://github.com/log2timeline/plaso/commit/c9ef97618447438b6bf283e56e7364ec... is going to affect your CL. So please update from origin master.
9 years ago (2015-04-01 06:31:32 UTC) #6
Joachim Metz
On 2015/04/01 06:31:32, Joachim Metz wrote: > know that: > https://github.com/log2timeline/plaso/commit/c9ef97618447438b6bf283e56e7364ec... > is going to ...
8 years, 12 months ago (2015-04-01 19:27:18 UTC) #7
f-s-p
On 2015/04/01 19:27:18, Joachim Metz wrote: > On 2015/04/01 06:31:32, Joachim Metz wrote: > > ...
8 years, 12 months ago (2015-04-02 12:29:38 UTC) #8
Joachim Metz
> Thank you! It looks like you are not converting the 'parent' back to an ...
8 years, 12 months ago (2015-04-02 13:09:39 UTC) #9
Joachim Metz
Sorry not paying attention > It looks like you are not converting the 'parent' back ...
8 years, 12 months ago (2015-04-02 13:13:12 UTC) #10
Joachim Metz
FYI this CL is affected by: https://codereview.appspot.com/224140043/
8 years, 11 months ago (2015-04-08 16:23:17 UTC) #11
Joachim Metz
On 2015/04/08 16:23:17, Joachim Metz wrote: > FYI this CL is affected by: https://codereview.appspot.com/224140043/ I ...
8 years, 11 months ago (2015-04-08 20:25:32 UTC) #12
f-s-p
On 2015/04/08 20:25:32, Joachim Metz wrote: > On 2015/04/08 16:23:17, Joachim Metz wrote: > > ...
8 years, 11 months ago (2015-04-09 00:09:09 UTC) #13
Joachim Metz
CL => Change list (http://en.wikipedia.org/wiki/Revision_control) Both of them have pros and cons, codereview (or rietveld) ...
8 years, 11 months ago (2015-04-09 04:33:31 UTC) #14
f-s-p
On 2015/04/09 04:33:31, Joachim Metz wrote: > CL => Change list (http://en.wikipedia.org/wiki/Revision_control) > > Both ...
8 years, 11 months ago (2015-04-17 15:07:49 UTC) #15
Joachim Metz
8 years, 11 months ago (2015-04-17 17:51:42 UTC) #16
> Regarding the reviewer process, you may be interested in this article:
>   http://blog.spreedly.com/2014/06/24/merge-pull-request-considered-harmful/

Thanks for the tip, we recently also discovered https://reviewable.io/
Looks like it might be worth a trial.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b