Code updated.
. https://codereview.appspot.com/224610044/diff/20001/tools/pinfo.py File tools/pinfo.py (right): https://codereview.appspot.com/224610044/diff/20001/tools/pinfo.py#newcode202 tools/pinfo.py:202: u'-d', u'--detail', dest=u'verbose', action=u'store_true', see that the pinfo CL changes the default setting for version to -V instead of -v so this might not be a necessary change (but there might still be a confusion between version and verbose, which is the same here as in detail vs. debug)
I don't agree with a lot of the changes. Also what are the reasons for some of them? https://codereview.appspot.com/224610044/diff/20001/plaso/multi_processing/mu... File plaso/multi_processing/multi_process.py (right): https://codereview.appspot.com/224610044/diff/20001/plaso/multi_processing/mu... plaso/multi_processing/multi_process.py:99: if not self._IsWorkerMonitored(worker_process): At this point this method is called the workers monitoring should not be relevant and this not necessary. https://codereview.appspot.com/224610044/diff/20001/plaso/multi_processing/mu... plaso/multi_processing/multi_process.py:128: continue At this point this method is called the workers monitoring should not be relevant and this not necessary. https://codereview.appspot.com/224610044/diff/20001/plaso/multi_processing/mu... plaso/multi_processing/multi_process.py:148: if not self._IsWorkerMonitored(worker_process): At this point this method is called the workers monitoring should not be relevant and this not necessary. https://codereview.appspot.com/224610044/diff/20001/plaso/multi_processing/mu... plaso/multi_processing/multi_process.py:177: if not self._IsWorkerMonitored(worker_process): At this point this method is called the workers monitoring should not be relevant and this not necessary. https://codereview.appspot.com/224610044/diff/20001/plaso/multi_processing/mu... plaso/multi_processing/multi_process.py:189: def _IsWorkerMonitored(self, worker_process): Shouldn't this be in the foreman? https://codereview.appspot.com/224610044/diff/20001/plaso/multi_processing/mu... plaso/multi_processing/multi_process.py:376: self._storage_writer_process.daemon = True The storage process is managed by main process why do you need to set daemon? https://codereview.appspot.com/224610044/diff/20001/plaso/multi_processing/mu... plaso/multi_processing/multi_process.py:418: # If the worker is not being monitored there is no need to go through NO, the main process needs to manage its child processes. https://codereview.appspot.com/224610044/diff/20001/tools/pinfo.py File tools/pinfo.py (right): https://codereview.appspot.com/224610044/diff/20001/tools/pinfo.py#newcode202 tools/pinfo.py:202: u'-d', u'--detail', dest=u'verbose', action=u'store_true', On 2015/04/26 02:08:01, kiddi wrote: > see that the pinfo CL changes the default setting for version to -V instead of > -v so this might not be a necessary change (but there might still be a confusion > between version and verbose, which is the same here as in detail vs. debug) I opt to stick with verbose it is more widely used than detail.