Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(98)

Issue 22450043: code review 22450043: go.talks: Show "run" button only for files with extensi... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 2 months ago by francesc
Modified:
7 years, 2 months ago
Reviewers:
adg, iant
CC:
adg, r, iant, golang-dev
Visibility:
Public.

Description

go.talks: Show "run" button only for files with extension .go if running on App Engine

Patch Set 1 #

Patch Set 2 : diff -r 53e8e0f32967 https://code.google.com/p/go.talks #

Patch Set 3 : diff -r 53e8e0f32967 https://code.google.com/p/go.talks #

Patch Set 4 : diff -r 53e8e0f32967 https://code.google.com/p/go.talks #

Patch Set 5 : diff -r 53e8e0f32967 https://code.google.com/p/go.talks #

Patch Set 6 : diff -r 53e8e0f32967 https://code.google.com/p/go.talks #

Patch Set 7 : diff -r 53e8e0f32967 https://code.google.com/p/go.talks #

Patch Set 8 : diff -r 53e8e0f32967 https://code.google.com/p/go.talks #

Patch Set 9 : diff -r 53e8e0f32967 https://code.google.com/p/go.talks #

Patch Set 10 : diff -r 53e8e0f32967 https://code.google.com/p/go.talks #

Patch Set 11 : diff -r 53e8e0f32967 https://code.google.com/p/go.talks #

Patch Set 12 : diff -r 53e8e0f32967 https://code.google.com/p/go.talks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M present/appengine.go View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M present/dir.go View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M present/local.go View 1 1 chunk +4 lines, -0 lines 0 comments Download
M present/templates/action.tmpl View 1 6 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
francesc
Hello adg@golang.org, r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.talks
7 years, 2 months ago (2013-11-06 19:48:26 UTC) #1
iant
LGTM
7 years, 2 months ago (2013-11-06 20:36:32 UTC) #2
adg
LGTM
7 years, 2 months ago (2013-11-06 23:50:41 UTC) #3
francesc
7 years, 2 months ago (2013-11-07 02:07:17 UTC) #4
*** Submitted as
https://code.google.com/p/go/source/detail?r=590f2d4cd69a&repo=talks ***

go.talks: Show "run" button only for files with extension .go if running on App
Engine

R=adg, r, iant
CC=golang-dev
https://codereview.appspot.com/22450043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b