Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(394)

Issue 223420043: Rewrite chordnames - disentangle data from formatting

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by thomasmorley651
Modified:
4 years ago
Reviewers:
marc, carl.d.sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Rewrite chordnames - disentangle data from formatting Issue 4344 Store all data to print a chordmarkup in an alist. Provide formatter for the elements of a chord and a final formatter outputting the result. Rename some rewritten procedures from scm/chord-name.scm reflecting the new behaviour. With the need to change those names in ly/engraver-init.ly and ly/property-init.ly as well. The old 'alteration->text-accidental-markup' was used for bass-figures in scm/translation-functions.scm. Thus inserted there. scm/chord-generic-names.scm is fixed only so far that it does compile. For a full test uncomment the section with the Banter-style in /Documentation/included/chord-names-jazz.ly

Patch Set 1 #

Patch Set 2 : Fix tabs #

Total comments: 10

Patch Set 3 : deeper disentangle, fixing TODOs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+606 lines, -242 lines) Patch
M ly/engraver-init.ly View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ly/property-init.ly View 1 chunk +6 lines, -6 lines 0 comments Download
M scm/chord-generic-names.scm View 1 2 3 chunks +17 lines, -9 lines 0 comments Download
M scm/chord-ignatzek-names.scm View 1 2 8 chunks +521 lines, -139 lines 0 comments Download
M scm/chord-name.scm View 1 2 1 chunk +50 lines, -85 lines 0 comments Download
M scm/define-context-properties.scm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scm/translation-functions.scm View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 7
thomasmorley651
Fix tabs
4 years, 1 month ago (2015-04-11 22:06:49 UTC) #1
thomasmorley651
Please review. Intended is a pure maintaining change. Maybe a first step for more flexibility, ...
4 years, 1 month ago (2015-04-11 22:17:53 UTC) #2
marc
Hi Harm, I cannot comment much on the code, but I like the general approach ...
4 years, 1 month ago (2015-04-12 06:43:43 UTC) #3
Carl
I think that this is a great start. You're working in a really complex area, ...
4 years, 1 month ago (2015-04-13 02:22:15 UTC) #4
thomasmorley651
deeper disentangle, fixing TODOs
4 years ago (2015-04-26 20:17:57 UTC) #5
thomasmorley651
On 2015/04/13 02:22:15, Carl wrote: > I think that this is a great start. You're ...
4 years ago (2015-04-26 20:24:08 UTC) #6
thomasmorley651
4 years ago (2015-04-26 20:30:11 UTC) #7
Although, this is not the final patch for this topic, James, may I ask you to
run patchy against it?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b