Gauss-Markov Mobility Model in ns-3

This patch adds a new mobility model to the ns-3 mobility directory. It is a 3D adaptation of the Gauss-Markov mobility model. Unlike the other mobility models in ns-3, which are memoryless, the Gauss Markov model has both memory and variability. The tunable alpha parameter determines the how much memory and randomness you want to model.
This version is suited for simple airplane flight, where direction, velocity, and pitch are the key variables.
The motion field is limited by a 3D bounding box (called "box") which is a 3D version of the "rectangle" that currently exists in ns-3 mobility models. I also added a new position allocation scheme to allow the initial positioning of modes in 3D space.

[Josh Pelkey, 2010-02-25 19:09:17]

Code looks good, should slide right in.  A few very minor comments below.

http://codereview.appspot.com/223048/diff/1/5
File src/mobility/position-allocator.h (right):

http://codereview.appspot.com/223048/diff/1/5#newcode185
src/mobility/position-allocator.h:185: * according to a pair of random
variables.
...within a box according to a 3-tuple (trio?) of random variables

http://codereview.appspot.com/223048/diff/7/1008
File src/mobility/gauss-markov-mobility-model.cc (right):

http://codereview.appspot.com/223048/diff/7/1008#newcode101
src/mobility/gauss-markov-mobility-model.cc:101: {
indent braces

http://codereview.appspot.com/223048/diff/7/1008#newcode169
src/mobility/gauss-markov-mobility-model.cc:169: {
indent braces, along with the next 2 if statements

http://codereview.appspot.com/223048/diff/7/1008#newcode221
src/mobility/gauss-markov-mobility-model.cc:221: //void
remove if not needed

http://codereview.appspot.com/223048/diff/7/1009
File src/mobility/gauss-markov-mobility-model.h (right):

http://codereview.appspot.com/223048/diff/7/1009#newcode55
src/mobility/gauss-markov-mobility-model.h:55: //  void DoSetVelocity (const
Vector &vel);
remove any unneeded code

[Mathieu Lacage, 2010-02-26 09:43:41]

The patch looks good. The documentation of GaussMarkovMobilityModel should be
extended to include the introductory comments to your patchset + at least a
reference to a paper or a book explaining what the original gauss markov
mobility model is.

http://codereview.appspot.com/223048/diff/11/1024
File src/mobility/position-allocator.h (right):

http://codereview.appspot.com/223048/diff/11/1024#newcode209
src/mobility/position-allocator.h:209: class RandomBoxPositionAllocator : public
PositionAllocator
I see the same declaration twice ?

[muxman, 2010-02-27 02:27:03]

On 2010/02/26 09:43:41, Mathieu Lacage wrote:
> The patch looks good. The documentation of GaussMarkovMobilityModel should be
> extended to include the introductory comments to your patchset + at least a
> reference to a paper or a book explaining what the original gauss markov
> mobility model is.
> 
> http://codereview.appspot.com/223048/diff/11/1024
> File src/mobility/position-allocator.h (right):
> 
> http://codereview.appspot.com/223048/diff/11/1024#newcode209
> src/mobility/position-allocator.h:209: class RandomBoxPositionAllocator :
public
> PositionAllocator
> I see the same declaration twice ?

Thanks Mathieu. The double declaration is a mistake I will correct. How do I add
the introductory comments to the documentation for the model? Do I insert them
as comments at the head of the gauss-markov-mobility-model.cc file or is there a
more formal way?

Dan

[Josh Pelkey, 2010-02-28 17:32:58]

On 2010/02/27 02:27:03, muxman wrote:
> On 2010/02/26 09:43:41, Mathieu Lacage wrote:
> > The patch looks good. The documentation of GaussMarkovMobilityModel should
be
> > extended to include the introductory comments to your patchset + at least a
> > reference to a paper or a book explaining what the original gauss markov
> > mobility model is.
> > 
> > http://codereview.appspot.com/223048/diff/11/1024
> > File src/mobility/position-allocator.h (right):
> > 
> > http://codereview.appspot.com/223048/diff/11/1024#newcode209
> > src/mobility/position-allocator.h:209: class RandomBoxPositionAllocator :
> public
> > PositionAllocator
> > I see the same declaration twice ?
> 
> Thanks Mathieu. The double declaration is a mistake I will correct. How do I
add
> the introductory comments to the documentation for the model? Do I insert them
> as comments at the head of the gauss-markov-mobility-model.cc file or is there
a
> more formal way?
> 
> Dan

I think integrating them with the brief description in
gauss-markov-mobility-model.h should work fine.  I am +1 for merge with that
addition.

[Mathieu Lacage, 2010-03-01 09:40:52]

On Sat, Feb 27, 2010 at 3:27 AM,  <muxman@sbcglobal.net> wrote:

> Thanks Mathieu. The double declaration is a mistake I will correct. How
> do I add the introductory comments to the documentation for the model?
> Do I insert them as comments at the head of the
> gauss-markov-mobility-model.cc file or is there a more formal way?

I think that it's best to add them in the doxygen of the
GaussMarkovMobilityModel class.

Mathieu
-- 
Mathieu Lacage <mathieu.lacage@gmail.com>

[Josh Pelkey, 2010-03-01 15:56:57]

On 2010/03/01 09:40:52, Mathieu Lacage wrote:
> On Sat, Feb 27, 2010 at 3:27 AM,  <mailto:muxman@sbcglobal.net> wrote:
> 
> > Thanks Mathieu. The double declaration is a mistake I will correct. How
> > do I add the introductory comments to the documentation for the model?
> > Do I insert them as comments at the head of the
> > gauss-markov-mobility-model.cc file or is there a more formal way?
> 
> I think that it's best to add them in the doxygen of the
> GaussMarkovMobilityModel class.
> 
> Mathieu
> -- 
> Mathieu Lacage <mailto:mathieu.lacage@gmail.com>
> 

Mathieu,

Dan uploaded patchset 4 which has more documentation in
src/mobility/gauss-markov-mobility-model.h.  Could you have another look?

[Mathieu Lacage, 2010-03-02 08:18:58]

It's good for me so, +1 but it would be really nice if you could include a link
or a pointer to a reference text which explains where these gauss/markov
mobility models are coming from. I obviously don't know anything about them.

[Josh Pelkey, 2010-03-03 16:14:19]

Thanks Dan!
Merged with ns-3-dev: changeset 38066d5d262b