Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2000)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 221880043: Added more formatter tests for issue #99. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 1 month ago by Joachim Metz
Modified:
9 years, 1 month ago
Reviewers:
kiddi, onager
CC:
log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Submitted. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+495 lines, -64 lines) Patch
M config/dpkg/changelog View 1 1 chunk +1 line, -1 line 0 comments Download
M plaso/formatters/filestat.py View 1 chunk +1 line, -1 line 0 comments Download
M plaso/formatters/interface.py View 1 4 chunks +4 lines, -2 lines 0 comments Download
M plaso/formatters/pcap.py View 2 chunks +2 lines, -2 lines 0 comments Download
A plaso/formatters/pcap_test.py View 1 chunk +44 lines, -0 lines 0 comments Download
M plaso/formatters/plist.py View 1 chunk +2 lines, -2 lines 0 comments Download
A plaso/formatters/plist_test.py View 1 chunk +35 lines, -0 lines 0 comments Download
M plaso/formatters/pls_recall.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
A plaso/formatters/pls_recall_test.py View 1 1 chunk +36 lines, -0 lines 0 comments Download
M plaso/formatters/popcontest.py View 2 chunks +3 lines, -3 lines 0 comments Download
A plaso/formatters/popcontest_test.py View 1 chunk +59 lines, -0 lines 0 comments Download
M plaso/formatters/recycler.py View 3 chunks +29 lines, -29 lines 0 comments Download
A plaso/formatters/recycler_test.py View 1 chunk +36 lines, -0 lines 0 comments Download
M plaso/formatters/safari.py View 1 chunk +7 lines, -4 lines 0 comments Download
M plaso/formatters/safari_cookies.py View 1 chunk +2 lines, -2 lines 0 comments Download
A plaso/formatters/safari_cookies_test.py View 1 chunk +36 lines, -0 lines 0 comments Download
A plaso/formatters/safari_test.py View 1 chunk +36 lines, -0 lines 0 comments Download
M plaso/formatters/selinux.py View 1 chunk +2 lines, -2 lines 0 comments Download
A plaso/formatters/selinux_test.py View 1 chunk +35 lines, -0 lines 0 comments Download
M plaso/formatters/shell_items.py View 2 chunks +2 lines, -2 lines 0 comments Download
A plaso/formatters/shell_items_test.py View 1 chunk +38 lines, -0 lines 0 comments Download
M plaso/formatters/skydrivelog.py View 1 chunk +2 lines, -2 lines 0 comments Download
A plaso/formatters/skydrivelog_test.py View 1 chunk +35 lines, -0 lines 0 comments Download
M plaso/formatters/skydrivelogerr.py View 1 chunk +2 lines, -2 lines 0 comments Download
A plaso/formatters/skydrivelogerr_test.py View 1 chunk +36 lines, -0 lines 0 comments Download
M plaso/parsers/pls_recall.py View 1 6 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 4
Joachim Metz
9 years, 1 month ago (2015-03-26 22:09:42 UTC) #1
onager
Minor docstring issue. LGTM https://codereview.appspot.com/221880043/diff/1/plaso/formatters/pls_recall.py File plaso/formatters/pls_recall.py (right): https://codereview.appspot.com/221880043/diff/1/plaso/formatters/pls_recall.py#newcode2 plaso/formatters/pls_recall.py:2: """The PL-Sql Recall event formatter.""" ...
9 years, 1 month ago (2015-03-27 10:52:49 UTC) #2
Joachim Metz
https://codereview.appspot.com/221880043/diff/1/plaso/formatters/pls_recall.py File plaso/formatters/pls_recall.py (right): https://codereview.appspot.com/221880043/diff/1/plaso/formatters/pls_recall.py#newcode2 plaso/formatters/pls_recall.py:2: """The PL-Sql Recall event formatter.""" On 2015/03/27 10:52:49, onager ...
9 years, 1 month ago (2015-03-27 12:48:21 UTC) #3
Joachim Metz
9 years, 1 month ago (2015-03-27 12:49:50 UTC) #4 
Code Submitted.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b