Issue 221870043: TBR: i#1551 port to ARM: set ISA mode for patch_branch of cti-short-rewrite

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 221870043: TBR: i#1551 port to ARM: set ISA mode for patch_branch of cti-short-rewrite

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years ago by bruening

Modified:
9 years ago

Reviewers:
zhaoqin

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#1551 port to ARM: set ISA mode for patch_branch of cti-short-rewrite We need to explicitly set the ISA mode for patch_branch()'s call to instr_is_cti_short_rewrite() as we don't have the instr_t and the decode_raw_is_jmp() call will fail if we have the wrong mode. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -13 lines)			Patch
	M	core/arch/arm/emit_utils.c	View		2 chunks	+21 lines, -13 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

9 years ago (2015-03-26 20:54:46 UTC) #2

Committed as
https://github.com/DynamoRIO/dynamorio/commit/5ed1d1b3c82186b37f04bcaf4b81480...

Final commit log: 
---------------
i#1551 port to ARM: set ISA mode for patch_branch of cti-short-rewrite

We need to explicitly set the ISA mode for patch_branch()'s call to
instr_is_cti_short_rewrite() as we don't have the instr_t and the
decode_raw_is_jmp() call will fail if we have the wrong mode.

Review-URL: https://codereview.appspot.com/221870043
---------------

Expand All Messages | Collapse All Messages